[PATCH 03/12] gdiplus: Introduce absdiff helper.

[Jacek Caban]

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com>
---
  dlls/gdiplus/image.c | 7 ++++++-
  1 file changed, 6 insertions(+), 1 deletion(-)

[Esme Povirk (they/them)]

What's the advantage over abs?

Should this function be inline?

[Chip Davis]

May 28, 2020 7:04 PM, "Esme Povirk (they/them)" <vincent(a)codeweavers.com> wrote:
> What's the advantage over abs?

It avoids a corner case where the difference between the two is really large. Partly for this reason, Clang warns when the argument to an abs(3) function is unsigned, even after I tried to get them to stop doing it for differences.

Chip

[Esme Povirk (they/them)]

On Thu, May 28, 2020 at 7:19 PM Chip Davis <cdavis(a)codeweavers.com> wrote:
> It avoids a corner case where the difference between the two is really large. Partly for this reason, Clang warns when the argument to an abs(3) function is unsigned, even after I tried to get them to stop doing it for differences.

So it's primarily to silence a warning? It's not clear to me when abs
would behave differently.

[Esme Povirk (they/them)]

Signed-off-by: Esme Povirk <vincent(a)codeweavers.com>