Re: Eliminate casts of the return value of HeapAlloc

[Francois Gouget]

On Mon, 21 Mar 2005, Alexandre Julliard wrote:
[...]
> Log message:
>   Mike McCormack <mike(a)codeweavers.com>
>   Eliminate casts of the return value of HeapAlloc.

This could be turned into a pretty easy janitorial the starting point of 
which would be the output of this command:

find . -name "*.[ch]" | xargs egrep "\) *Heap(Re)?Alloc"
(344 lines)

There are a couple of places where the output of HeapAlloc is being cast 
to a DWORD but except for those it seems pretty straightforward.


-- 
Francois Gouget         fgouget(a)free.fr        http://fgouget.free.fr/
                           La terre est une b\xEAta...

Eliminate casts of the return value of HeapAlloc

[Dimitrie O. Paun]

On Mon, Mar 21, 2005 at 02:03:59PM +0100, Francois Gouget wrote:
> On Mon, 21 Mar 2005, Alexandre Julliard wrote:
> [...]
> > Log message:
> >   Mike McCormack <mike(a)codeweavers.com>
> >   Eliminate casts of the return value of HeapAlloc.
>
> This could be turned into a pretty easy janitorial the starting point of 
> which would be the output of this command:
>
> find . -name "*.[ch]" | xargs egrep "\) *Heap(Re)?Alloc"
> (344 lines)
>
> There are a couple of places where the output of HeapAlloc is being cast 
> to a DWORD but except for those it seems pretty straightforward.

Yeah, it's so straightforward, we should just do it.
However, I don't think we should sed it, most places
require human touch to maintain sane formatting.

I'll send in a patch for windows/*.c shortly.

-- 
Dimi.

Eliminate casts of the return value of HeapAlloc

[Mike McCormack]

Dimitrie O. Paun wrote:
> Yeah, it's so straightforward, we should just do it.
> However, I don't think we should sed it, most places
> require human touch to maintain sane formatting.

Well, it's always nice to leave some entry level tasks behind for people 
who want to start working on Wine.  They're really easy to do, but by 
writing the patch, and submitting it, newcomers can learn alot about the 
patch submission process.

Mike