Re: [PATCH] wined3d: Dont just print a FIXME on error, handle it (Coverity)
11 Jun
2011
11 Jun
'11
3:53 p.m.
On 11 June 2011 17:26, Marcus Meissner <marcus(a)jet.franken.de> wrote:
if (state <= HIGHEST_TRANSFORMSTATE) + { mat = &device->updateStateBlock->state.transforms[state]; + } else + { FIXME("Unhandled transform state %#x.\n", state); + return WINED3D_OK; + }
This works, so I'm not too bothered either way, but I think the following looks slightly nicer: if (state > HIGHEST_TRANSFORMSTATE) { WARN("Invalid transform state %#x.\n", state); return WINED3D_OK; } mat = &device->updateStateBlock->state.transforms[state]; multiply_matrix(&temp, mat, matrix);
5302
Age (days ago)
5302
Last active (days ago)
0 comments
1 participants
participants (1)
-
Henri Verbeet