Re: rpcrt4: Restore original error code when ReadFile fails with ERROR_MORE_DATA.
Sebastian Lackner <sebastian(a)fds-team.de> writes:
Required when named pipe messagemode is implemented.
Restoring last error is in general wrong. You'll need a better reason to justify this. -- Alexandre Julliard julliard(a)winehq.org
On 09.06.2015 10:31, Alexandre Julliard wrote:
Sebastian Lackner <sebastian(a)fds-team.de> writes:
Required when named pipe messagemode is implemented.
Restoring last error is in general wrong. You'll need a better reason to justify this.
The problem I am trying to fix with this patch occurs during connection teardown. See for example setupapi.SetupInstallServicesFromInfSectionW, where the error code is set before calling CloseServiceHandle(), which will send additional RPC messages. The alternative solutions would be: * Only restore error code for CloseServiceHandle() * Restructure setupapi code to set the error as a last step, after calling CloseServiceHandle. Regards, Sebastian
Sebastian Lackner <sebastian(a)fds-team.de> writes:
* Restructure setupapi code to set the error as a last step, after calling CloseServiceHandle.
Yes, last error should always be set as the last step. Any call in between can legitimately modify it. -- Alexandre Julliard julliard(a)winehq.org
participants (2)
-
Alexandre Julliard -
Sebastian Lackner