Re: Add missing FreeLibrary calls

[Alexandre Julliard]

James Hawkins <truiken(a)gmail.com> writes:
> Index: dlls/gdi/tests/gdiobj.c
> ===================================================================
> RCS file: /home/wine/wine/dlls/gdi/tests/gdiobj.c,v
> retrieving revision 1.10
> diff -u -p -r1.10 gdiobj.c
> --- dlls/gdi/tests/gdiobj.c	26 Oct 2005 10:10:23 -0000	1.10
> +++ dlls/gdi/tests/gdiobj.c	29 Nov 2005 04:25:18 -0000
> @@ -274,9 +274,13 @@ static void test_GdiGetCharDimensions(vo
>      LONG ret;
>      SIZE size;
>      LONG avgwidth, height;
> +    HMODULE hGDI;
>      static const char szAlphabet[] = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz";
>      typedef LONG (WINAPI *fnGdiGetCharDimensions)(HDC hdc, LPTEXTMETRICW lptm, LONG *height);
> -    fnGdiGetCharDimensions GdiGetCharDimensions = (fnGdiGetCharDimensions)GetProcAddress(LoadLibrary("gdi32"), "GdiGetCharDimensions");
> +    fnGdiGetCharDimensions GdiGetCharDimensions;
> +    hGDI = LoadLibrary("gdi32");
> +    GdiGetCharDimensions = (fnGdiGetCharDimensions)GetProcAddress(hGDI, "GdiGetCharDimensions");
> +    FreeLibrary(hGDI);

You can't free libraries that will be called later on. And there's no
reason to free anything in tests, everything is freed on exit anyway.

-- 
Alexandre Julliard
julliard(a)winehq.org