Re: [ntdll] Add tests for NtQueryInformationFile
On 09/09/2009 02:41 PM, Dan Kegel wrote:
Alexandre said I should break up the big xattr patch, so here are just the NtQueryInformationFile tests, improved a bit. Once these are in I'll submit the NtQueryDirectoryFile tests.
Passes on both Wine and Vista.
------------------------------------------------------------------------
Hi Dan, This patch introduces some issues on NT4 and higher. Attached patch fixes it but I'm not sure if you are already chasing these failures. Weird that it doesn't fail on your Vista box. That remark "whoops, vista doesn't implement this one?\n" should probably be changed. It also looks like Vista/Win7 has either 2 or 4 failures (most likely related to indexing being disabled, if so that could also happen on other platforms). Not sure if we should explicitly check for attributes being 2020, ignore FILE_ATTRIBUTE_NOT_CONTENT_INDEXED or just check as I did. -- Cheers, Paul.
On 09/10/2009 10:35 PM, Paul Vriens wrote:
On 09/09/2009 02:41 PM, Dan Kegel wrote:
Alexandre said I should break up the big xattr patch, so here are just the NtQueryInformationFile tests, improved a bit. Once these are in I'll submit the NtQueryDirectoryFile tests.
Passes on both Wine and Vista.
------------------------------------------------------------------------
Hi Dan,
This patch introduces some issues on NT4 and higher. Attached patch fixes it but I'm not sure if you are already chasing these failures. Weird that it doesn't fail on your Vista box.
That remark "whoops, vista doesn't implement this one?\n" should probably be changed.
It also looks like Vista/Win7 has either 2 or 4 failures (most likely related to indexing being disabled, if so that could also happen on other platforms). Not sure if we should explicitly check for attributes being 2020, ignore FILE_ATTRIBUTE_NOT_CONTENT_INDEXED or just check as I did.
Weird, just saw the results of my Vista box on test.winehq.org. It shows 4 failures but if I run them standalone (crosscompiled) I only have 2. -- Cheers, Paul.
On Thu, Sep 10, 2009 at 1:37 PM, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote:
It also looks like Vista/Win7 has either 2 or 4 failures (most likely related to indexing being disabled, if so that could also happen on other platforms). Not sure if we should explicitly check for attributes being 2020, ignore FILE_ATTRIBUTE_NOT_CONTENT_INDEXED or just check as I did.
Weird, just saw the results of my Vista box on test.winehq.org. It shows 4 failures but if I run them standalone (crosscompiled) I only have 2.
And I still have zero failures on my Vista Home box! Go ahead and submit that patch, please... I can't reproduce the problem, and my wrists have flared up again, making it risky for me to type much for now. - Dan
On Thu, Sep 10, 2009 at 1:35 PM, Paul Vriens<paul.vriens.wine(a)gmail.com> wrote:
Passes on both Wine and Vista.
This patch introduces some issues on NT4 and higher. Attached patch fixes it but I'm not sure if you are already chasing these failures. Weird that it doesn't fail on your Vista box.
Must have been user error on my part. I think I was sleepy when I was preparing that patch. I'll try to send in an updated fix tonight. Thanks! - Dan
On 09/10/2009 10:49 PM, Dan Kegel wrote:
On Thu, Sep 10, 2009 at 1:35 PM, Paul Vriens<paul.vriens.wine(a)gmail.com> wrote:
Passes on both Wine and Vista.
This patch introduces some issues on NT4 and higher. Attached patch fixes it but I'm not sure if you are already chasing these failures. Weird that it doesn't fail on your Vista box.
Must have been user error on my part. I think I was sleepy when I was preparing that patch. I'll try to send in an updated fix tonight. Thanks! - Dan
Ok, just sent the patch (changed that 'whoops' text). Still weird that you don't and I only have 2 failures (whereas test.winehq.org shows 4 for me). -- Cheers, Paul.
participants (2)
-
Dan Kegel -
Paul Vriens