Re: [10/10] rpcrt4: Add tests for RPC calls with authentication.
Hi Rob, I took the liberty of running these tests on winetestbot. It shows two errors for W2K and above: https://winetestbot.geldorp.nl/JobDetails.pl?Key=115 -- Cheers, Paul.
On Monday 14 December 2009 10:41:12 Paul Vriens wrote:
I took the liberty of running these tests on winetestbot. It shows two errors for W2K and above:
I wrote those tests originally, so I'll fix it :) -Hans
On 12/14/2009 11:45 AM, Hans Leidekker wrote:
On Monday 14 December 2009 10:41:12 Paul Vriens wrote:
I took the liberty of running these tests on winetestbot. It shows two errors for W2K and above:
I wrote those tests originally, so I'll fix it :)
-Hans
Ah, I missed that From-address in the patch. Or actually, I didn't even look. -- Cheers, Paul.
2009/12/14 Hans Leidekker <hans(a)codeweavers.com>:
On Monday 14 December 2009 10:41:12 Paul Vriens wrote:
I took the liberty of running these tests on winetestbot. It shows two errors for W2K and above:
I wrote those tests originally, so I'll fix it :)
Those failures only occur because of modifications I made to them, but thanks for fixing it anyway! -- Rob Shearman
On 12/14/2009 11:45 AM, Hans Leidekker wrote:
On Monday 14 December 2009 10:41:12 Paul Vriens wrote:
I took the liberty of running these tests on winetestbot. It shows two errors for W2K and above:
I wrote those tests originally, so I'll fix it :)
-Hans
Hi Hans, I didn't notice the crash on NT4 at winetestbot till after I checked test.winehq.org: https://winetestbot.geldorp.nl/JobDetails.pl?Key=116&scrshot_101=1#k101 There are also some extra failures on Win9x/WinMe: http://test.winehq.org/data/tests/rpcrt4:server.html Could you have a look? -- Cheers, Paul.
On 12/14/2009 08:35 PM, Paul Vriens wrote:
On 12/14/2009 11:45 AM, Hans Leidekker wrote:
On Monday 14 December 2009 10:41:12 Paul Vriens wrote:
I took the liberty of running these tests on winetestbot. It shows two errors for W2K and above:
I wrote those tests originally, so I'll fix it :)
-Hans
Hi Hans, We still have a crash on NT4 and failures on Win9x. I don't know why win9x doesn't crash as well as we are using some uninitialzed string if GetUserNameExA is not available. Does the attached make sense? -- Cheers, Paul.
On Tuesday 15 December 2009 20:09:12 Paul Vriens wrote:
We still have a crash on NT4 and failures on Win9x. I don't know why win9x doesn't crash as well as we are using some uninitialzed string if GetUserNameExA is not available.
Does the attached make sense?
That works, but it would be cleaner to move the check for pGetUserNameExA close to where its result is used. So into set_auth_info and s_authinfo_test(). That may also allow some more tests to run on nt4. -Hans
On 12/15/2009 08:46 PM, Hans Leidekker wrote:
On Tuesday 15 December 2009 20:09:12 Paul Vriens wrote:
We still have a crash on NT4 and failures on Win9x. I don't know why win9x doesn't crash as well as we are using some uninitialzed string if GetUserNameExA is not available.
Does the attached make sense?
That works, but it would be cleaner to move the check for pGetUserNameExA close to where its result is used. So into set_auth_info and s_authinfo_test(). That may also allow some more tests to run on nt4.
Ok, just sent that patch (and a patch to 'fix' some Win9x/WinME failures). -- Cheers, Paul.
participants (3)
-
Hans Leidekker -
Paul Vriens -
Rob Shearman