Re: [PATCH 1/4] msi: speed up WHERE statement evaluation by evaluating the condition as early as possible
31 Aug
2011
31 Aug
'11
10:25 a.m.
Bernhard Loos <bernhardloos(a)googlemail.com> writes:
@@ -639,6 +715,8 @@ static UINT WHERE_execute( struct tagMSIVIEW *view, MSIRECORD *record ) while ((table = table->next));
rows = msi_alloc( wv->table_count * sizeof(*rows) ); + memset( rows, 0xFF, sizeof( rows ) ); +
If the goal is to set them to -1, please do that explicitly. Also defining some appropriate constant for invalid rows would be even better. -- Alexandre Julliard julliard(a)winehq.org
5218
Age (days ago)
5218
Last active (days ago)
0 comments
1 participants
participants (1)
-
Alexandre Julliard