Re: [2/7] shlwapi/tests: Add tests for StrStrA.

[Detlef Riekenberg]

Hi Andrew.

While reading your Patches, i stumble over deadbeef.

We use the value 0xdeadbeef almost everywhere in the tests
to initialize a variable to an unusual value.

Using deadbeef as a variable name looks strange and make the
code harder to read and understand.

Please change the name in your Patchset.

-- 
By by ... Detlef
___________________________________________________________
Neu: GMX De-Mail - Einfach wie E-Mail, sicher wie ein Brief!  
Jetzt De-Mail-Adresse reservieren: http://portal.gmx.net/de/go/demail

[2/7] shlwapi/tests: Add tests for StrStrA.

[Andrew Nguyen]

On 07/19/2010 11:01 AM, Detlef Riekenberg wrote:
> Hi Andrew.
>
> While reading your Patches, i stumble over deadbeef.
>
> We use the value 0xdeadbeef almost everywhere in the tests
> to initialize a variable to an unusual value.
>
> Using deadbeef as a variable name looks strange and make the
> code harder to read and understand.
>
> Please change the name in your Patchset.

Sure, I can rename the "deadbeef" strings to "deadbeefA" to mirror 
"deadbeefW", if that's acceptable.