Re: [2/2]try3.add new dll. wbemprox.dll

[Detlef Riekenberg]

On Fr, 2008-03-07 at 13:19 +0300, Ivan Sinitsin wrote:
> This patch add new library to the project wine. Name of the library 
> is - "wbemprox.dll".

Since you read the Developer-Hints, you are now aware, that
"Makefile.in" is wrong here.

I have no Idea about COM, but you should studdy commits for new dlls,
when COM functionality was added (Patch-Size, Complexity).

Since you used some code from Roy as template, i suggest to study 
the commits for his recent Patches. 
As Examples:
http://source.winehq.org/git/wine.git/?a=history;f=dlls/qmgrprxy or
http://source.winehq.org/git/wine.git/?a=history;f=dlls/qmgr



A "\n" at the start of a TRACE is wrong.
A "\t" in a TRACE is not needed.

A FIXME for an unimplemented function is a good idea, but a simple
FIXME("\n");
is not informative.

Thanks for helping Wine


-- 
 
By by ... Detlef