Re: [PATCH 1/5] wininet: Add Internet{Set, Query}Option tests, implement POLICY option
Andrew Eikum <aeikum(a)codeweavers.com> writes:
diff --git a/dlls/wininet/tests/Makefile.in b/dlls/wininet/tests/Makefile.in index ba8f662..66a756f 100644 --- a/dlls/wininet/tests/Makefile.in +++ b/dlls/wininet/tests/Makefile.in @@ -10,6 +10,7 @@ CTESTS = \ generated.c \ http.c \ internet.c \ + option.c \
This can go with the other internet tests in internet.c, there's no need for a new file. -- Alexandre Julliard julliard(a)winehq.org
On 01/19/2010 05:34 AM, Alexandre Julliard wrote:
Andrew Eikum<aeikum(a)codeweavers.com> writes:
diff --git a/dlls/wininet/tests/Makefile.in b/dlls/wininet/tests/Makefile.in index ba8f662..66a756f 100644 --- a/dlls/wininet/tests/Makefile.in +++ b/dlls/wininet/tests/Makefile.in @@ -10,6 +10,7 @@ CTESTS = \ generated.c \ http.c \ internet.c \ + option.c \
This can go with the other internet tests in internet.c, there's no need for a new file.
I can certainly do it this way. My concern is that there are over 100 options for both Query and Set, and while only 3 are implemented by this series, I think the file might become difficult to manage as more become implemented. Andrew
Andrew Eikum <andrew(a)brightnightgames.com> writes:
This can go with the other internet tests in internet.c, there's no need for a new file.
I can certainly do it this way. My concern is that there are over 100 options for both Query and Set, and while only 3 are implemented by this series, I think the file might become difficult to manage as more become implemented.
If we really get tests for 100 options and the file becomes unmanageable, it can be split at that point. In general the size of the file is not a big issue for tests, the code is fairly repetitive. -- Alexandre Julliard julliard(a)winehq.org
participants (2)
-
Alexandre Julliard -
Andrew Eikum