Re: [1/2] hlink/tests: display the expected data, as well as the actual data.

[James Hawkins]

On Sun, Sep 7, 2008 at 4:56 AM, Reece Dunn <msclrhd(a)googlemail.com> wrote:
> This improves the error reporting for the hlink tests.

I think you need to think this one over.  Why would we care to display
the expected data, when the expected data is in the tests?  For simple
tests, e.g. last errors or simple integer results, displaying the
expected data makes it easier to understand the returned value.  On
the other hand, for the hlink tests, the expected binary data adds no
value to the output.

-- 
James Hawkins

[1/2] hlink/tests: display the expected data, as well as the actual data.

[Reece Dunn]

2008/9/7 James Hawkins <truiken(a)gmail.com>:
> On Sun, Sep 7, 2008 at 4:56 AM, Reece Dunn <msclrhd(a)googlemail.com> wrote:
> > This improves the error reporting for the hlink tests.
>
> I think you need to think this one over.  Why would we care to display
> the expected data, when the expected data is in the tests?  For simple
> tests, e.g. last errors or simple integer results, displaying the
> expected data makes it easier to understand the returned value.  On
> the other hand, for the hlink tests, the expected binary data adds no
> value to the output.

Ok, I'll remove this one and just provide the 2nd patch.

I'm currently fixing the secur32:schannel tests, so I'll do that once
those have been addressed.

Thanks,
- Reece