Re: [PATCH 1/2] ntdll/tests: Add SIMD exception test for floating point invalid operation fault (try 3).

[Alexandre Julliard]

Qian Hong <qhong(a)codeweavers.com> writes:
> Try 3:
> - Correctly revert side effect of previous ldmxcsr, change 0x200 to
> 0x80, 0x80 & 0xff7f = 0, 0x200 & 0xfdff = 0.

It would be even better to restore the original value, without making
assumptions about the previous contents.

-- 
Alexandre Julliard
julliard(a)winehq.org

[PATCH 1/2] ntdll/tests: Add SIMD exception test for floating point invalid operation fault (try 3).

[Qian Hong]

On Wed, Dec 2, 2015 at 9:21 PM, Alexandre Julliard <julliard(a)winehq.org> wrote:
> It would be even better to restore the original value, without making
> assumptions about the previous contents.

Thanks for comment, I'll send a v4. Would you want me also change the
existent code in simd_exception_test or just leave it in the old way?




-- 
Regards,
Qian Hong

-
http://www.codeweavers.com

[PATCH 1/2] ntdll/tests: Add SIMD exception test for floating point invalid operation fault (try 3).

[Alexandre Julliard]

Qian Hong <qhong(a)codeweavers.com> writes:
> On Wed, Dec 2, 2015 at 9:21 PM, Alexandre Julliard <julliard(a)winehq.org> wrote:
> > It would be even better to restore the original value, without making
> > assumptions about the previous contents.
>
> Thanks for comment, I'll send a v4. Would you want me also change the
> existent code in simd_exception_test or just leave it in the old way?

If you could, fixing the existing code too would be great.

-- 
Alexandre Julliard
julliard(a)winehq.org

[PATCH 1/2] ntdll/tests: Add SIMD exception test for floating point invalid operation fault (try 3).

[Qian Hong]

On Wed, Dec 2, 2015 at 10:30 PM, Alexandre Julliard <julliard(a)winehq.org> wrote:
> If you could, fixing the existing code too would be great.

Thanks for comment, will send as a separate patch.


-- 
Regards,
Qian Hong

-
http://www.codeweavers.com