Re: [PATCH] gdiplus: Scale widened dashes to the pen width.

[Vincent Povirk]

If the dash_pos variable is relative to pen width, we need to fix the
other references to it. It doesn't make sense to compare it directly
with segment_length and segment_pos.

Or we could scale the whole dash_pattern array by pen width at the start.

[PATCH] gdiplus: Scale widened dashes to the pen width.

[Zebediah Figura]

On 06/27/2017 03:27 PM, Vincent Povirk wrote:
> If the dash_pos variable is relative to pen width, we need to fix the
> other references to it. It doesn't make sense to compare it directly
> with segment_length and segment_pos.
>
> Or we could scale the whole dash_pattern array by pen width at the start.

If it is, I can fix that and resend. I hadn't bothered looking and just 
assumed it was unitless for some reason.

[PATCH] gdiplus: Scale widened dashes to the pen width.

[Vincent Povirk]

Well, you need to decide that. You changed its meaning in one place
but not everywhere.

On Tue, Jun 27, 2017 at 3:58 PM, Zebediah Figura
<zfigura(a)codeweavers.com> wrote:
> On 06/27/2017 03:27 PM, Vincent Povirk wrote:
> > If the dash_pos variable is relative to pen width, we need to fix the
> > other references to it. It doesn't make sense to compare it directly
> > with segment_length and segment_pos.
> >
> > Or we could scale the whole dash_pattern array by pen width at the start.
>
> If it is, I can fix that and resend. I hadn't bothered looking and just
> assumed it was unitless for some reason.