Re: [5/5] comctl32/treeview: Don't send TVN_ITEMEXPANDING when item has no children

[Alexandre Julliard]

Nikolay Sivov <nsivov(a)codeweavers.com> writes:
> Fix for http://bugs.winehq.org/show_bug.cgi?id=23591
>
> From 3bb38e13558c6e06efbb33b7e24cc36c4ae5973f Mon Sep 17 00:00:00 2001
> From: Nikolay Sivov <nsivov(a)codeweavers.com>
> Date: Sat, 14 May 2011 20:03:40 +0400
> Subject: [PATCH 5/5] Don't send TVN_ITEMEXPANDING when item has no children

It doesn't work here:

../../../tools/runtest -q -P wine -M explorerframe.dll -T ../../.. -p explorerframe_test.exe.so nstc.c && touch nstc.ok
nstc.c:1668: Test failed: Got 0x80070057
nstc.c:1933: Test failed: Got event 6, count 0
nstc.c:1934: Test failed: Got event 7, count 0
nstc.c:1935: Test failed: No event.
nstc.c:1949: Test failed: Got event 4, count 0
nstc.c:1999: Test failed: Got event 6, count 0
nstc.c:2000: Test failed: No event.
nstc.c:2001: Test failed: Got event 7, count 0
nstc.c:2010: Test failed: Item not expanded.
nstc.c:2030: Test failed: itemstate is 0x00000000
nstc.c:2080: Test succeeded inside todo block: Got event 6, count 0
nstc.c:2081: Test succeeded inside todo block: Got event 7, count 0
nstc.c:2082: Test succeeded inside todo block: Got event 12, count 0
nstc.c:2090: Test succeeded inside todo block: itemstate is 0x00000000
nstc.c:2163: Test failed: itemstate is 0x00000000
nstc.c:2216: Test failed: itemstate is 0x00000004
nstc.c:2228: Test failed: itemstate is 0x00000004
nstc.c:2283: Test failed: Got event 6, count 0
nstc.c:2284: Test failed: No event.
nstc.c:2285: Test failed: Got event 7, count 0
nstc.c:2290: Test failed: Got (0x80004005)
nstc.c:2291: Test failed: psi is (nil)
make: *** [nstc.ok] Error 22

-- 
Alexandre Julliard
julliard(a)winehq.org

[5/5] comctl32/treeview: Don't send TVN_ITEMEXPANDING when item has no children

[Nikolay Sivov]

On Mon, May 16, 2011 at 2:11 PM, Alexandre Julliard <julliard(a)winehq.org> wrote:
> Nikolay Sivov <nsivov(a)codeweavers.com> writes:
> > Fix for http://bugs.winehq.org/show_bug.cgi?id=23591
> >
> > From 3bb38e13558c6e06efbb33b7e24cc36c4ae5973f Mon Sep 17 00:00:00 2001
> > From: Nikolay Sivov <nsivov(a)codeweavers.com>
> > Date: Sat, 14 May 2011 20:03:40 +0400
> > Subject: [PATCH 5/5] Don't send TVN_ITEMEXPANDING when item has no children
>
> It doesn't work here:

Mmm, ok. I'll test this thing with native comctl32 too.
> ../../../tools/runtest -q -P wine -M explorerframe.dll -T ../../.. -p explorerframe_test.exe.so nstc.c && touch nstc.ok
> nstc.c:1668: Test failed: Got 0x80070057
> nstc.c:1933: Test failed: Got event 6, count 0
> nstc.c:1934: Test failed: Got event 7, count 0
> nstc.c:1935: Test failed: No event.
> nstc.c:1949: Test failed: Got event 4, count 0
> nstc.c:1999: Test failed: Got event 6, count 0
> nstc.c:2000: Test failed: No event.
> nstc.c:2001: Test failed: Got event 7, count 0
> nstc.c:2010: Test failed: Item not expanded.
> nstc.c:2030: Test failed: itemstate is 0x00000000

----
> nstc.c:2080: Test succeeded inside todo block: Got event 6, count 0
> nstc.c:2081: Test succeeded inside todo block: Got event 7, count 0
> nstc.c:2082: Test succeeded inside todo block: Got event 12, count 0
> nstc.c:2090: Test succeeded inside todo block: itemstate is 0x00000000

Bright side of it.
> nstc.c:2163: Test failed: itemstate is 0x00000000
> nstc.c:2216: Test failed: itemstate is 0x00000004
> nstc.c:2228: Test failed: itemstate is 0x00000004
> nstc.c:2283: Test failed: Got event 6, count 0
> nstc.c:2284: Test failed: No event.
> nstc.c:2285: Test failed: Got event 7, count 0
> nstc.c:2290: Test failed: Got (0x80004005)
> nstc.c:2291: Test failed: psi is (nil)
> make: *** [nstc.ok] Error 22
>
> --
> Alexandre Julliard
> julliard(a)winehq.org