Re: msvcirt: Share exceptions implementation with msvcp
Iván Matellanes <matellanesivan(a)gmail.com> writes:
This is the first patch of my GSoC project :) It implements the exceptions in msvcirt by using the code in msvcp90.
@@ -304,13 +304,15 @@ typedef enum __exception_type { EXCEPTION_RERAISE, EXCEPTION, EXCEPTION_BAD_ALLOC, - EXCEPTION_BAD_CAST, EXCEPTION_LOGIC_ERROR, +#ifndef _MSVCIRT EXCEPTION_LENGTH_ERROR, EXCEPTION_OUT_OF_RANGE, EXCEPTION_INVALID_ARGUMENT, EXCEPTION_RUNTIME_ERROR, EXCEPTION_FAILURE, + EXCEPTION_BAD_CAST, +#endif
Please avoid as many ifdefs as possible. For instance, having extra enums or unexported functions doesn't do any harm, so there's no reason to make a special case for them. -- Alexandre Julliard julliard(a)winehq.org
On 05/26/15 07:41, Alexandre Julliard wrote:
Please avoid as many ifdefs as possible. For instance, having extra enums or unexported functions doesn't do any harm, so there's no reason to make a special case for them.
Some of the exception classes depend on basic_string class that is not available in msvcirt. What's the preferred way of dealing with them? Should we ifdef them out or e.g. define fake MSVCP_basic_string_char_ctor_cstr, MSVCP_basic_string_char_c_str and MSVCP_basic_string_char_dtor just to make it compile?
Piotr Caban <piotr.caban(a)gmail.com> writes:
On 05/26/15 07:41, Alexandre Julliard wrote:
Please avoid as many ifdefs as possible. For instance, having extra enums or unexported functions doesn't do any harm, so there's no reason to make a special case for them.
Some of the exception classes depend on basic_string class that is not available in msvcirt. What's the preferred way of dealing with them? Should we ifdef them out or e.g. define fake MSVCP_basic_string_char_ctor_cstr, MSVCP_basic_string_char_c_str and MSVCP_basic_string_char_dtor just to make it compile?
ifdefs are fine in that case. -- Alexandre Julliard julliard(a)winehq.org
participants (2)
-
Alexandre Julliard -
Piotr Caban