Re: msxml3: Don't return implementation pointer as an interface.
21 Jan
2014
21 Jan
'14
5:14 a.m.
On 1/21/2014 09:08, Dmitry Timoshkov wrote:
--- dlls/msxml3/xmlelem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dlls/msxml3/xmlelem.c b/dlls/msxml3/xmlelem.c index 2130c713..c525c8b 100644 --- a/dlls/msxml3/xmlelem.c +++ b/dlls/msxml3/xmlelem.c @@ -663,7 +663,7 @@ static HRESULT WINAPI xmlelem_collection_get__newEnum(IXMLElementCollection *ifa if (!ppUnk) return E_INVALIDARG;
- *ppUnk = (IUnknown *)This; + *ppUnk = (IUnknown *)&This->IXMLElementCollection_iface; IUnknown_AddRef(*ppUnk); return S_OK; } It's not necessary wrong, but it's possible it returns IEnumVARIANT here, it's easy to test.
4344
Age (days ago)
4344
Last active (days ago)
0 comments
1 participants
participants (1)
-
Nikolay Sivov