Re: Dylan Smith : d3dx9/tests: Added tests for D3DXCreateSkinInfo.
Hello Dylan, Alexandre Julliard wrote:
Module: wine Branch: master Commit: 01ff07e2e1d2e77575ddbd88a705ef12ea6f9073 URL: http://source.winehq.org/git/wine.git/?a=commit;h=01ff07e2e1d2e77575ddbd88a7...
Author: Dylan Smith <dylan.ah.smith(a)gmail.com> Date: Wed Jun 22 14:24:41 2011 -0400
d3dx9/tests: Added tests for D3DXCreateSkinInfo.
---
dlls/d3dx9_36/tests/mesh.c | 229 ++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 229 insertions(+), 0 deletions(-)
Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=01ff07e2e1d2e77575ddbd... this commit breaks compilation on my old RHEL5 box: dlls/d3dx9_36/tests/mesh.c:4813: error: ‘FP_NAN’ undeclared (first use in this function)
bye michael
On 24 June 2011 14:31, Michael Stefaniuc <mstefani(a)redhat.com> wrote:
Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=01ff07e2e1d2e77575ddbd... this commit breaks compilation on my old RHEL5 box: dlls/d3dx9_36/tests/mesh.c:4813: error: ‘FP_NAN’ undeclared (first use in this function)
Austin English ran in to the same problem: http://bugs.winehq.org/show_bug.cgi?id=27583 Alex
On Friday 24 June 2011 15:38:41 Alex Bradbury wrote:
On 24 June 2011 14:31, Michael Stefaniuc <mstefani(a)redhat.com> wrote:
Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=01ff07e2e1d2e7757 5ddbd88a705ef12ea6f9073
this commit breaks compilation on my old RHEL5 box: dlls/d3dx9_36/tests/mesh.c:4813: error: ‘FP_NAN’ undeclared (first use in this function)
Austin English ran in to the same problem: http://bugs.winehq.org/show_bug.cgi?id=27583 I'd appreciate a portable solution for generating NaN and Inf values as well, I have the same problem with wined3d in visual studio.
On Fri, Jun 24, 2011 at 9:31 AM, Michael Stefaniuc <mstefani(a)redhat.com> wrote:
this commit breaks compilation on my old RHEL5 box: dlls/d3dx9_36/tests/mesh.c:4813: error: ‘FP_NAN’ undeclared (first use in this function)
Does the attached patch fix the problem. It uses 0.0f / 0.0f like in wined3d_private.h. On Fri, Jun 24, 2011 at 9:44 AM, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote:
I'd appreciate a portable solution for generating NaN and Inf values as well, I have the same problem with wined3d in visual studio.
I don't see Inf values specified using a macro there, but good for future reference.
On Friday 24 June 2011 16:01:21 Dylan Smith wrote:
On Fri, Jun 24, 2011 at 9:31 AM, Michael Stefaniuc <mstefani(a)redhat.com> wrote:
this commit breaks compilation on my old RHEL5 box: dlls/d3dx9_36/tests/mesh.c:4813: error: ‘FP_NAN’ undeclared (first use in this function)
Does the attached patch fix the problem. It uses 0.0f / 0.0f like in wined3d_private.h. Ya, visual studio reports a divide by zero error in this case :-/
On Fri, Jun 24, 2011 at 10:19 AM, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote:
On Friday 24 June 2011 16:01:21 Dylan Smith wrote:
On Fri, Jun 24, 2011 at 9:31 AM, Michael Stefaniuc <mstefani(a)redhat.com> wrote:
this commit breaks compilation on my old RHEL5 box: dlls/d3dx9_36/tests/mesh.c:4813: error: ‘FP_NAN’ undeclared (first use in this function)
Does the attached patch fix the problem. It uses 0.0f / 0.0f like in wined3d_private.h. Ya, visual studio reports a divide by zero error in this case :-/
I see. I suppose NAN isn't crucial to the tests (the point is the value is not checked), so I could assume the IEEE 745 standard since it shouldn't break the tests if this assumption is wrong. So how about the revised patch that uses memset to set all the bits to 1. On Fri, Jun 24, 2011 at 10:56 AM, Dan Kegel <dank(a)kegel.com> wrote:
Dylan wrote: - exp_weights[1] = FP_NAN; + exp_weights[1] = 0.0f / 0.0f;
It's a bit strange to see 0 being replaced with infinity. What is your intent in that line? FP_NAN probably isn't what you think it is.
0.0f / 0.0f seems to give NAN as a result, although using a comment or an appropriately named variable would make it more readable. The intent is to show that the value isn't checked, since usually weights are between 0.0 and 1.0.
On Fri, Jun 24, 2011 at 11:04 AM, Dylan Smith <dylan.ah.smith(a)gmail.com> wrote:
So how about the revised patch that uses memset to set all the bits to 1.
Oops, forgot to diff against origin. Attached patch against origin.
Thanks Dylan, Dylan Smith wrote:
On Fri, Jun 24, 2011 at 9:31 AM, Michael Stefaniuc <mstefani(a)redhat.com> wrote:
this commit breaks compilation on my old RHEL5 box: dlls/d3dx9_36/tests/mesh.c:4813: error: ‘FP_NAN’ undeclared (first use in this function)
Does the attached patch fix the problem. It uses 0.0f / 0.0f like in wined3d_private.h. WORKSFORME.
On Fri, Jun 24, 2011 at 9:44 AM, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote:
I'd appreciate a portable solution for generating NaN and Inf values as well, I have the same problem with wined3d in visual studio.
I don't see Inf values specified using a macro there, but good for future reference.
bye michael
participants (4)
-
Alex Bradbury -
Dylan Smith -
Michael Stefaniuc -
Stefan Dösinger