Re: winedump: Add initial support for handling EMF+ records

[Dmitry Timoshkov]

Piotr Caban <piotr(a)codeweavers.com> wrote:
> #define EMRCASE(x) case x: printf("%-20s %08x\n", #x, length); break
> +#define EMRPLUSCASE(x) case x: printf("    %-20s %04x %08x\n", #x, header->Flags, header->Size); break;

';' at the end is redundant. EMRCASE macro intentionally omits it.
> +        /* Hand EMF+ records */
> +        if (length >= 16 && !memcmp((char*)PRD(offset + 12, sizeof(unsigned int)), "EMF+", 4))

A typo in the comment.

-- 
Dmitry.

winedump: Add initial support for handling EMF+ records

[Piotr Caban]

On 06/30/17 17:50, Dmitry Timoshkov wrote:
> Piotr Caban <piotr(a)codeweavers.com> wrote:
> > #define EMRCASE(x) case x: printf("%-20s %08x\n", #x, length); break
> > +#define EMRPLUSCASE(x) case x: printf("    %-20s %04x %08x\n", #x, header->Flags, header->Size); break;
>
> ';' at the end is redundant. EMRCASE macro intentionally omits it.
> > +        /* Hand EMF+ records */
> > +        if (length >= 16 && !memcmp((char*)PRD(offset + 12, sizeof(unsigned int)), "EMF+", 4))
>
> A typo in the comment.
> Thanks, I'll send a fixed version.