Re: [PATCH 1/13] msidb: Add stub tool for manipulating MSI databases.

[Hans Leidekker]

On Sun, 2017-04-09 at 13:12 -0600, Erich E. Hoover wrote:
> +    /* process and validate all the command line flags */
> +    for (i = 1; n && i < argc; i += n)
> +        n = process_argument( &state, i, argc, argv );
> +    if (!valid_state( &state ))
> +        return 1;
> +
> +    /* perform the requested operations */
> +    if (!open_database( &state ))
> +    {
> +        ERR( "Failed to open database '%s'.\n", wine_dbgstr_w(state.database_file) );

For programs it should be WINE_ERR, etc.

[PATCH 1/13] msidb: Add stub tool for manipulating MSI databases.

[Alexandre Julliard]

Hans Leidekker <hans(a)codeweavers.com> writes:
> On Sun, 2017-04-09 at 13:12 -0600, Erich E. Hoover wrote:
> > +    /* process and validate all the command line flags */
> > +    for (i = 1; n && i < argc; i += n)
> > +        n = process_argument( &state, i, argc, argv );
> > +    if (!valid_state( &state ))
> > +        return 1;
> > +
> > +    /* perform the requested operations */
> > +    if (!open_database( &state ))
> > +    {
> > +        ERR( "Failed to open database '%s'.\n", wine_dbgstr_w(state.database_file) );
>
> For programs it should be WINE_ERR, etc.

Actually we build programs with __WINESRC__ these days, so it no longer
matters.

-- 
Alexandre Julliard
julliard(a)winehq.org