Re: [PATCH 2/8] server: Pass async_data_t as varargs in write request.

[Jacek Caban]

On 06.04.2017 17:58, Jacek Caban wrote:
> This is needed for later patch that adds APCs to async_data_t, causing 
> request to exceed allowed size.

Having second thoughts about it, I think there is a solution that 
doesn't require changing async_data_t size. We could require that the 
first field of callback argument is a pointer to callback. This way we 
could have just one pointer for callback and its argument, saving space 
for APC in async_data_t. Please let me know if that would be preferred.

Thanks,
Jacek

[PATCH 2/8] server: Pass async_data_t as varargs in write request.

[Alexandre Julliard]

Jacek Caban <jacek(a)codeweavers.com> writes:
> On 06.04.2017 17:58, Jacek Caban wrote:
> > This is needed for later patch that adds APCs to async_data_t,
> > causing request to exceed allowed size.
>
> Having second thoughts about it, I think there is a solution that
> doesn't require changing async_data_t size. We could require that the
> first field of callback argument is a pointer to callback. This way we
> could have just one pointer for callback and its argument, saving
> space for APC in async_data_t. Please let me know if that would be
> preferred.

That's probably worth a try, yes.

-- 
Alexandre Julliard
julliard(a)winehq.org