Re: [5/5] WineD3D: Manage private data in a wine linked list
On 09/05/07, Stefan Dösinger <stefan(a)codeweavers.com> wrote:
Fixes an endless loop in the startup of Traffic Giant.
Shouldn't you free the private data when the resource is destroyed? (MSDN claims you should).
Am Mittwoch 09 Mai 2007 18:33 schrieb H. Verbeet:
On 09/05/07, Stefan Dösinger <stefan(a)codeweavers.com> wrote:
Fixes an endless loop in the startup of Traffic Giant.
Shouldn't you free the private data when the resource is destroyed? (MSDN claims you should). Yes, this makes sense, especially since we allocate the memory for it. I'll write a test testing that with an IUnknown data storage.
(But this should go in a different patch, since the old code didn't free it either. The patch is just fixing the data structure, not the behavior)
On 09/05/07, Stefan Dösinger <stefan(a)codeweavers.com> wrote:
(But this should go in a different patch, since the old code didn't free it either. The patch is just fixing the data structure, not the behavior)
Yeah, it's just that this patch made me look at that part of the code.
participants (2)
-
H. Verbeet -
Stefan Dösinger