[PATCH 1/2] winex11.drv: Warn about missing libxcursor library
* When using a color cursor without libxcursor the fallback path will use just 2 colors or a monochrome one Signed-off-by: Daniel Ansorregui <mailszeros(a)gmail.com> --- dlls/winex11.drv/mouse.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/dlls/winex11.drv/mouse.c b/dlls/winex11.drv/mouse.c index d6787068a9..aaf5e2b382 100644 --- a/dlls/winex11.drv/mouse.c +++ b/dlls/winex11.drv/mouse.c @@ -56,6 +56,7 @@ MAKE_FUNCPTR(XcursorLibraryLoadCursor); #include "wine/debug.h" WINE_DEFAULT_DEBUG_CHANNEL(cursor); +WINE_DECLARE_DEBUG_CHANNEL(winediag); /**********************************************************************/ @@ -1379,7 +1380,9 @@ static Cursor create_cursor( HANDLE handle ) #ifdef SONAME_LIBXCURSOR if (pXcursorImagesLoadCursor) cursor = create_xcursor_cursor( hdc, &info, handle, bm.bmWidth, bm.bmHeight ); -#endif +#else /* SONAME_LIBXCURSOR */ + ERR_(winediag)("xcursor was not available at compile time and color cursor was requested.\n"); +#endif /* SONAME_LIBXCURSOR */ if (!cursor) cursor = create_xlib_load_mono_cursor( hdc, handle, bm.bmWidth, bm.bmHeight ); if (!cursor) cursor = create_xlib_color_cursor( hdc, &info, bm.bmWidth, bm.bmHeight ); DeleteObject( info.hbmColor ); -- 2.17.1
Daniel Ansorregui <mailszeros(a)gmail.com> writes:
* When using a color cursor without libxcursor the fallback path will use just 2 colors or a monochrome one
Since there's a fallback, this should be at most a WARN, and even that is debatable since there's no warning for the libxcursor missing at runtime case. -- Alexandre Julliard julliard(a)winehq.org
participants (2)
-
Alexandre Julliard -
Daniel Ansorregui