Re: comdlg32: Avoid possible NULL pointer dereference (Coverity)

[Kai Blin]

On Tuesday 14 October 2008 11:10:34 Kai Blin wrote:
> As the code checks for ofnW->lpstrFile not being NULL, it seems like
> PathFindFileNameW() and PathFindExtensionW() don't make sense on NULL
> ofnW->lpstrFile. If offset and extension are not updated, it doesn't make
> sense to call UpdateResults. So just abort if ofnW->lpstrFile is NULL.
>
> This fixes Coverity CID 108
> ---
>  dlls/comdlg32/filedlg31.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)

Of course I forgot to switch the logic. New patch coming up.


-- 
Kai Blin
WorldForge developer  http://www.worldforge.org/
Wine developer        http://wiki.winehq.org/KaiBlin
Samba team member     http://www.samba.org/samba/team/
--
Will code for cotton.