Re: [PATCHv2 3/3] d3d9/tests: Add tests for different YUV texture layouts

[Stefan Dösinger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

You still have a few formatting issues in this patch, I've quoted the
ones I found below.

I ran the test on my Windows boxes and it passed on the following devices:

Windows 7 x86_64, Radeon HD 5770
Windows 7 x86_64, Radeon X1600
Windows 7 x32, Nvidia GeForce 9600
Windows Vista x32, Nvidia GeForce 7400

It did not pass on my very ancient Windows XP x32 laptop with a Radeon
9000 Mobility. It fails there the same way as on the testbot - the
card claims to support YUY2 and YV12, but the StretchRect call fails
with D3DERR_INVALIDCALL. Do you have any idea why that might happen?
If not maybe the best solution is to accept the error with broken()
and skip the rest of the test.

There's IDirect3D9::CheckDeviceFormatConversion, but according to msdn
it only tests backbuffer and adapter format compatibility. That's not
the way we implement it, but I don't think we have tests to find out
how it's really supposed to behave.

Fwiw none of the above machines claims I420 support. There are plenty
of other odd formats though.

Am 2014-02-12 21:05, schrieb Martin Storsjo:

Use 8 space indentation vs the first line of the if and put the &&
into the next line.


Same as above.


Curly bracket placement.


Same.


8 space indent on line contiuation as in if conditions.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJS/KsdAAoJEN0/YqbEcdMwckoP/RTST4uApXJwApHZeP5DC7M9
9gN0k8G/zKFN/79I9RPC/fVhMbk/uniloVK+uuYwKmNsoFLRnT1ikg320D09KclZ
R1+sLK3Cr9x8lR9NAbR/NsCglRupoE3qX916T1QVApWgeGb9WvExkto6rP+DhI8L
sw5T/Rtr3odiMKdSXyllXNgZl0cljhd821OXn5bl6A1VpRO5tXJr7WFfMSIl5TUT
VDOub/n2bPwKB38wUwxSgd+m/9hgl+4U+z4V1gfyichgVp4gZKSRH+mr96WI3trc
eGjWxtH4+kk1LLshxjCaQOJ0fqoMDQbxJjUBtkAqSKYbCvd7KEfbcTcyKfd4mOHX
ZgTqsMRlB/jVK2ugmojf2JgCasecDhENcibjOH2DHXe2SbUUx/QV7cFzjGEGiMNj
fOBW0B/f1WJHuyYcKrpw1EWhsR4lFjM6uehmNC+ndA78zy5NPg15U6iBS0ArwZLN
kSqbUd6VJy74zVs8CH/v6/cbjUhHguyYcO77/I7k9CMVV3rssgO2oV4GyOnfJGZg
dLqN+mQGD3mZhhBhTZrqmuSK1BoPMgA89O7kbJB/x+l3f5XNuCmCxzK4ydgUsr11
kJ/gjrnc51/snAE61+qUZ7sxvGdJKqNdk19Xwrtjp7z2NIcJaNVT8qB41JJFrr4/
Woj0DvcYK1wrmPg8XSJ3
=Hogg
-----END PGP SIGNATURE-----

[PATCHv2 3/3] d3d9/tests: Add tests for different YUV texture layouts

[Martin Storsjö]

On Thu, 13 Feb 2014, Stefan Dösinger wrote:
> You still have a few formatting issues in this patch, I've quoted the
> ones I found below.

The quotes seem to be missing, but I think I found the places you referred 
to. I'll resend the full set now.

// Martin