Re: msi [2/3]: Fix handling of published installer properties

[Alexandre Julliard]

"James Hawkins" <jhawkins(a)codeweavers.com> writes:
> The tests are in the next patch.  Fixes bug 7189.
> http://bugs.winehq.org/show_bug.cgi?id=7189

You need to fix the todo_wine tests in the same patch, I can't apply a
patch that causes failures:

../../../tools/runtest -q -P wine -M msi.dll -T ../../.. -p msi_test.exe.so install.c && touch install.ok
install.c:2233: Test succeeded inside todo block: Expected ERROR_FILE_NOT_FOUND, got 2
install.c:2259: Test succeeded inside todo block: Expected ERROR_FILE_NOT_FOUND, got 2
install.c:2341: Test succeeded inside todo block: Expected ERROR_FILE_NOT_FOUND, got 2
install.c:2469: Test succeeded inside todo block: Expected ERROR_FILE_NOT_FOUND, got 2
install.c:2495: Test succeeded inside todo block: Expected ERROR_FILE_NOT_FOUND, got 2
install.c:2610: Test succeeded inside todo block: Expected ERROR_FILE_NOT_FOUND, got 2
install.c:2633: Test succeeded inside todo block: Expected ERROR_FILE_NOT_FOUND, got 2
install.c:2797: Test succeeded inside todo block: Expected ERROR_FILE_NOT_FOUND, got 2
install.c:2823: Test succeeded inside todo block: Expected ERROR_FILE_NOT_FOUND, got 2
install.c:2900: Test succeeded inside todo block: Expected ERROR_FILE_NOT_FOUND, got 2
install.c:3241: Test succeeded inside todo block: Expected ERROR_FILE_NOT_FOUND, got 2
make: *** [install.ok] Error 11

And if I apply your 3/3 patch I now get:

../../../tools/runtest -q -P wine -M msi.dll -T ../../.. -p msi_test.exe.so install.c && touch install.ok
install.c:4398: Test failed: Expected ERROR_UNKNOWN_PRODUCT, got 0
make: *** [install.ok] Error 1

-- 
Alexandre Julliard
julliard(a)winehq.org