Re: mpr: Improve stubs for WNetGetUniversalName.

[James Hawkins]

On Wed, Aug 27, 2008 at 5:32 PM, Sergey Khodych <khodych(a)gmail.com> wrote:
> From 1dec9750bed16eaeff97cf88374954d5ebde383c Mon Sep 17 00:00:00 2001
> From: Sergey Khodych <khodych(a)gmail.com>
> Date: Thu, 28 Aug 2008 01:00:19 +0300
> Subject: mpr: Improve stubs for WNetGetUniversalName.

There are several things wrong with this patch:
* It's way too large.  Please split it up.
* No tests.  You need to write tests to back up these changes.
* You're changing the style of the file.  The original file does not
have spaces before or after parentheses.

http://wiki.winehq.org/SubmittingPatches

-- 
James Hawkins

mpr: Improve stubs for WNetGetUniversalName.

[Sergey Khodych]

James Hawkins wrote:
> There are several things wrong with this patch:
> * It's way too large.  Please split it up.
> * No tests.  You need to write tests to back up these changes.
> Are tests necessary for simple stubs? I don't know what kind of
> tests can be written for stubs, except tests for wrong input parameters.

mpr: Improve stubs for WNetGetUniversalName.

[James Hawkins]

On Thu, Aug 28, 2008 at 6:52 PM, Sergey Khodych <khodych(a)gmail.com> wrote:
> James Hawkins wrote:
> > There are several things wrong with this patch:
> > * It's way too large.  Please split it up.
> > * No tests.  You need to write tests to back up these changes.
>
> Are tests necessary for simple stubs? I don't know what kind of
> tests can be written for stubs, except tests for wrong input parameters.

Your changes move the functions out of the realm of simple stubs.

-- 
James Hawkins