Re: [PATCH 1/2] slc: Implement SLGetWindowsInformationDWORD

[Alexandre Julliard]

Detlef Riekenberg <wine.dev(a)web.de> writes:
> +HRESULT WINAPI SLGetWindowsInformationDWORD(LPCWSTR lpszValueName, LPDWORD pdwValue)
> +{
> +    FIXME("(%s, %p): semi-stub\n", debugstr_w(lpszValueName), pdwValue);
> +
> +    if (!lpszValueName || !pdwValue)
> +        return E_INVALIDARG;
> +
> +    if (!*lpszValueName)
> +        return SL_E_RIGHT_NOT_GRANTED;
> +
> +    /* We have always a genuine Wine */
> +    *pdwValue = 1;
> +    return S_OK;

There's no reason that this dword would represent the genuine flag, it
can be just about anything. Returning value not found would probably be
preferable, or else do a real attempt at determining what value would be
expected for the specified name.

-- 
Alexandre Julliard
julliard(a)winehq.org