Re: widl: Explicitly declare default function's calling convention to avoid win64 problems.

[Alexandre Julliard]

Jacek Caban <jacek(a)codeweavers.com> writes:
> @@ -369,7 +369,7 @@ static void write_type_v(FILE *h, type_t *t, int is_field, int declonly, const c
>      if (type_get_type_detect_alias(pt) == TYPE_FUNCTION) {
>        int i;
>        const char *callconv = get_attrp(pt->attrs, ATTR_CALLCONV);
> -      if (!callconv && is_object_interface) callconv = "STDMETHODCALLTYPE";
> +      if (!callconv) callconv = is_object_interface ? "STDMETHODCALLTYPE" : "__cdecl";

It may be useful to be able to declare functions that use the native
calling convention, I don't think we want to prevent that.

-- 
Alexandre Julliard
julliard(a)winehq.org

widl: Explicitly declare default function's calling convention to avoid win64 problems.

[Jacek Caban]

On 9/28/10 2:09 PM, Alexandre Julliard wrote:
> Jacek Caban<jacek(a)codeweavers.com>  writes:
> > @@ -369,7 +369,7 @@ static void write_type_v(FILE *h, type_t *t, int is_field, int declonly, const c
> >       if (type_get_type_detect_alias(pt) == TYPE_FUNCTION) {
> >         int i;
> >         const char *callconv = get_attrp(pt->attrs, ATTR_CALLCONV);
> > -      if (!callconv&&  is_object_interface) callconv = "STDMETHODCALLTYPE";
> > +      if (!callconv) callconv = is_object_interface ? "STDMETHODCALLTYPE" : "__cdecl";
> > It may be useful to be able to declare functions that use the native
> > calling convention, I don't think we want to prevent that.

Fair enough, I just wanted to make Wine safer for such cases.

Jacek