Re: [PATCH 1/3] d3dx9: Implement ID3DXBaseEffect::GetParameterByName().

[Henri Verbeet]

2011/4/20 Rico Schüller <kgbricola(a)web.de>:
> +inline LPSTR get_partial_string(LPCSTR name, char initial, char final)
> That should probably be static instead of inline. Also,
> get_parameter_by_name() looks like it could be split up, and you can
> probably avoid the copy in get_partial_string().

[PATCH 1/3] d3dx9: Implement ID3DXBaseEffect::GetParameterByName().

[Rico Schüller]

Am 21.04.2011 16:46, schrieb Henri Verbeet:
> 2011/4/20 Rico Schüller<kgbricola(a)web.de>:
> > +inline LPSTR get_partial_string(LPCSTR name, char initial, char final)
> > That should probably be static instead of inline. Also,
> > get_parameter_by_name() looks like it could be split up, and you can
> > probably avoid the copy in get_partial_string().

Something like the attached patch should be better in that regards. Any 
thoughts?

Cheers
Rico