Re: [PATCH v2 1/4] ddraw: Don't write out if a ddraw1 surface of size 0 is requested.

[Alex Henrie]

2017-01-27 5:43 GMT-07:00 Henri Verbeet <hverbeet(a)gmail.com>:
> On 26 January 2017 at 06:20, Alex Henrie <alexhenrie24(a)gmail.com> wrote:
> > +    hr = IDirectDraw_CreateSurface(ddraw, &surface_desc, &surface, NULL);
> > +    ok(hr == E_INVALIDARG, "Got unexpected hr %#x.\n", hr);
> > +    ok(surface == (IDirectDrawSurface *)0xdeadbeef || broken(!surface) /* 32-bit on Win8/10 */,
> > +            "Got unexpected surface %p.\n", surface);
> > Where does this pass without the broken()? It writes NULL to surface
> > for me on Windows 7, and appears to handle the exception when an
> > invalid pointer is passed in.

http://testbot.winehq.org/JobDetails.pl?Key=28086

The following testbot VMs are the only ones that zero out the surface pointer:

w8 (32 bit ddraw1)
w864 (32 bit ddraw1)
w1064 (32 bit ddraw1)

Maybe the behavior of newer versions of Windows depends on the video
card driver?

-Alex

---------- Forwarded message ----------
From: Marvin <testbot(a)winehq.org>
Date: 2017-01-27 10:00 GMT-07:00
Subject: TestBot job 28086 results: ddraw: Don't write out if a ddraw1
surface of size 0 is requested.
To: Alex Henrie <alexhenrie24(a)gmail.com>


VM                   Status    Number of test failures
build                completed
wxppro               completed 0
w2003std             completed 0
wvistau64            completed 0
w2008s64             completed 0
w7u                  completed 0
w7pro64              completed 0
w8                   completed 1
w864                 completed 1
w1064                completed 2
wvistau64            completed 0
w2008s64             completed 0
w7pro64              completed 0
w864                 completed 0
w1064                completed 1

=== build (build) ===
No build failures found

=== wxppro (32 bit ddraw1) ===
No test failures found

=== w2003std (32 bit ddraw1) ===
No test failures found

=== wvistau64 (32 bit ddraw1) ===
No test failures found

=== w2008s64 (32 bit ddraw1) ===
No test failures found

=== w7u (32 bit ddraw1) ===
No test failures found

=== w7pro64 (32 bit ddraw1) ===
No test failures found

=== w8 (32 bit ddraw1) ===

ddraw:
ddraw1.c:1971: Test failed: Got unexpected surface 00000000.

=== w864 (32 bit ddraw1) ===

ddraw:
ddraw1.c:1971: Test failed: Got unexpected surface 00000000.

=== w1064 (32 bit ddraw1) ===

ddraw:
ddraw1.c:1971: Test failed: Got unexpected surface 00000000.
ddraw1.c:2299: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768).

=== wvistau64 (64 bit ddraw1) ===
No test failures found

=== w2008s64 (64 bit ddraw1) ===
No test failures found

=== w7pro64 (64 bit ddraw1) ===
No test failures found

=== w864 (64 bit ddraw1) ===
No test failures found

=== w1064 (64 bit ddraw1) ===

ddraw:
ddraw1.c:2299: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768).

[PATCH v2 1/4] ddraw: Don't write out if a ddraw1 surface of size 0 is requested.

[Henri Verbeet]

On 27 January 2017 at 19:21, Alex Henrie <alexhenrie24(a)gmail.com> wrote:
> 2017-01-27 5:43 GMT-07:00 Henri Verbeet <hverbeet(a)gmail.com>:
> > Where does this pass without the broken()? It writes NULL to surface
> > for me on Windows 7, and appears to handle the exception when an
> > invalid pointer is passed in.
>
> http://testbot.winehq.org/JobDetails.pl?Key=28086
>
> The following testbot VMs are the only ones that zero out the surface pointer:
>
> w8 (32 bit ddraw1)
> w864 (32 bit ddraw1)
> w1064 (32 bit ddraw1)
>
> Maybe the behavior of newer versions of Windows depends on the video
> card driver?

Those are the only testbot VMs where the test gets run.
test_surface_qi() requires D3D, and that's only supported on the
Windows 8 and higher VMs. 64-bit ddraw doesn't support D3D at all.