Re: [1/n] vbscript: Added stub dll

[Nikolay Sivov]

Robert Wilhelm wrote:
> Second try, now patch as attachment.

1) Please don't add autogenerated files to patch.
   

----

 configure                     |    9 ++++
 configure.ac                  |    1 +
----

2) Patches [2/n] and [3/n].

Each patch should contain all related changes to be useful.
After your patch [2/n] resource file is unused.
Maybe it's better to merge [2/n] and [3/n]?

P.S. GUID_NULL is already defined in uuid.lib

[1/n] vbscript: Added stub dll

[Lei Zhang]

On Thu, Mar 5, 2009 at 3:37 PM, Nikolay Sivov <bunglehead(a)gmail.com> wrote:
> Robert Wilhelm wrote:
> > Second try, now patch as attachment.
>
> 1) Please don't add autogenerated files to patch.
>
> ----
>
> configure                     |    9 ++++
> configure.ac                  |    1 +
> ----

I thought we're suppose to add them.

http://source.winehq.org/git/wine.git/?a=history;f=configure

[1/n] vbscript: Added stub dll

[James Hawkins]

On Thu, Mar 5, 2009 at 4:16 PM, Lei Zhang <thestig(a)google.com> wrote:
> On Thu, Mar 5, 2009 at 3:37 PM, Nikolay Sivov <bunglehead(a)gmail.com> wrote:
> > Robert Wilhelm wrote:
> > > Second try, now patch as attachment.
> >
> > 1) Please don't add autogenerated files to patch.
> >
> > ----
> >
> > configure                     |    9 ++++
> > configure.ac                  |    1 +
> > ----
>
> I thought we're suppose to add them.
>
> http://source.winehq.org/git/wine.git/?a=history;f=configure

No, Julliard generates them for you and adds them in your name.

-- 
James Hawkins