Re: PATCH: Convert HDRVR to a void*

[Michael Stefaniuc]

Hello!

On Mon, Aug 05, 2002 at 12:41:35AM +0200, Michael Stefaniuc wrote:
> License: LGPL, X11
> Changelog:
>     Michael Stefaniuc <mstefani(a)redhat.com>
>     - Convert HDRVR to a void*
>     - Fix declaration of DriverCallback()
> Alexandre, please don't apply this patch because it's broken and I don't
> know which is the best/cleanest way to fix that.
> Problem: the macro HDRVR_16 defined in dlls/winmm/winemm.h is needed in
> dlls/msvideo/msvideo_main.c . Which of the following solutions is the
> way to go (the problem will also appear when the rest of the handles are
> converted to a void* too, so a generic solution would be best):
> 1.) just include dlls/winmm/winemm.h
> 2.) put the $HANDLE_{16,32} macros into include/wownt32.h surrounded by
>     #ifdef __WINE__ and include wownt32.h
> 3.) put the $HANDLE_{16,32} macros into one of the include/wine/*.h
>     header files (in which?)
> 4.) create include/wine/handleconv.h and put all handle conversions into
>     it

I would prefer 4 and 3 but I don't mind to do it in any way.

Comments?

bye
	michael
-- 
Michael Stefaniuc               Tel.: [phone]
System Administration           Fax.: [phone]
Red Hat GmbH                    Email: mstefani(a)redhat.com
Hauptstaetterstr. 58            http://www.redhat.de/
D-70178 Stuttgart

PATCH: Convert HDRVR to a void*

[Alexandre Julliard]

Michael Stefaniuc <mstefani(a)redhat.de> writes:
> 1.) just include dlls/winmm/winemm.h
> 2.) put the $HANDLE_{16,32} macros into include/wownt32.h surrounded by
>     #ifdef __WINE__ and include wownt32.h
> 3.) put the $HANDLE_{16,32} macros into one of the include/wine/*.h
>     header files (in which?)
> 4.) create include/wine/handleconv.h and put all handle conversions into
>     it
>
> I would prefer 4 and 3 but I don't mind to do it in any way.

5) duplicate the HDRVR_16 macro into msvideo.

This should be a rare problem since in general 16-bit functions are
not exported across dlls, so duplicating the macro shouldn't really be
a problem. And we can always change it later if it turns out that we
have a lot of duplicated stuff.

-- 
Alexandre Julliard
julliard(a)winehq.com