Re: ws2_32/tests: Add some tests for sockets bound to a completion port.
Dmitry Timoshkov <dmitry(a)baikal.ru> writes:
+ if (pNtClose) + { + pNtClose((HANDLE)src); + break; + } + win_skip("NtClose is not available on this platform"); + how_to_close = 1;
The test and skip are not necessary, we no longer support win9x in tests.
+ ok(ovl_iocp->Internal == STATUS_CONNECTION_ABORTED || STATUS_LOCAL_DISCONNECT /* XP */, "got %#lx\n", ovl_iocp->Internal);
The second part of the || is always true so this is not testing anything.
+ ok(ovl_iocp->Internal == STATUS_CONNECTION_ABORTED || STATUS_LOCAL_DISCONNECT /* XP */, "got %#lx\n", ovl_iocp->Internal);
Same here. -- Alexandre Julliard julliard(a)winehq.org
Alexandre Julliard <julliard(a)winehq.org> wrote:
+ ok(ovl_iocp->Internal == STATUS_CONNECTION_ABORTED || STATUS_LOCAL_DISCONNECT /* XP */, "got %#lx\n", ovl_iocp->Internal);
The second part of the || is always true so this is not testing anything.
+ ok(ovl_iocp->Internal == STATUS_CONNECTION_ABORTED || STATUS_LOCAL_DISCONNECT /* XP */, "got %#lx\n", ovl_iocp->Internal);
Same here.
Oops, thanks for spotting these glaring bugs. -- Dmitry.
participants (2)
-
Alexandre Julliard -
Dmitry Timoshkov