Howdy, I'm seeing a strange behavior and I thought I'd let the Devel community know about it: While using Agent v1.8, and while having a CD in my CD tray (although unmounted!), if I start agent under wine, I'm able to open and close my CD tray. However, if I try to use the attachment window to attach something, the CD-ROM drive spins up, and I'm unable to open it. Even if I attach nothing, the CD-ROM drive is claimed by wine so that I can't eject the Drive. Once I exit agent, the drive is released so that I can open the drive. Note that the CD-ROM was never mounted. Even a check during the blocked period shows no mounted device, even though the "eject' command says "device busy." Interestingly, when I just tried this again for this email, I noticed the following output messages (It seems that there are some floppy drive assumptions, also.) Oliver ---output---- err:dosfs:DRIVE_ReadSuperblock Couldn't open device '/dev/fd0' for drive A: ! (no permission) err:dosfs:DRIVE_ReadSuperblock Can't read drive volume info ! Either pre-set it or make sure the device to read it from is accessible ! Perhaps you have not properly edited or created your Wine configuration file. This is (supposed to be) '/home/olsam/.wine/config' err:dosfs:DRIVE_GetLabel Invalid or unreadable superblock on /dev/fd0 (A:). err:dosfs:DRIVE_ReadSuperblock Couldn't open device '/dev/fd0' for drive A: ! (no permission) err:dosfs:DRIVE_ReadSuperblock Can't read drive volume info ! Either pre-set it or make sure the device to read it from is accessible ! Perhaps you have not properly edited or created your Wine configuration file. This is (supposed to be) '/home/olsam/.wine/config' Invalid or unreadable superblock on /dev/fd0 (A:). Maybe not FAT? err:dosfs:DRIVE_ReadSuperblock The filesystem is not FAT !! (device=/dev/cdrom) err:dosfs:DRIVE_GetLabel Invalid or unreadable superblock on /dev/cdrom (D:). err:dosfs:DRIVE_ReadSuperblock The filesystem is not FAT !! (device=/dev/cdrom) Invalid or unreadable superblock on /dev/cdrom (D:). Maybe not FAT? fixme:listview:LISTVIEW_UnsupportedStyles LVS_EDITLABELS fixme:listview:LISTVIEW_UnsupportedStyles LVS_SHAREIMAGELISTS ==================================================== Oliver Sampson olsam(a)quickaudio.com http://www.oliversampson.com
On Mon, 22 Apr 2002, Oliver Sampson wrote:
Howdy, I'm seeing a strange behavior and I thought I'd let the Devel community know about it:
While using Agent v1.8, and while having a CD in my CD tray (although unmounted!), if I start agent under wine, I'm able to open and close my CD tray. However, if I try to use the attachment window to attach something, the CD-ROM drive spins up, and I'm unable to open it. Even if I attach nothing, the CD-ROM drive is claimed by wine so that I can't eject the Drive. Once I exit agent, the drive is released so that I can open the drive. Note that the CD-ROM was never mounted. Even a check during the blocked period shows no mounted device, even though the "eject' command says "device busy."
Interestingly, when I just tried this again for this email, I noticed the following output messages (It seems that there are some floppy drive assumptions, also.)
If you don't want Wine to attempt raw device access, don't give it a "Device" = in the [Drive X] entry, I think. Your average Windows app is inquisitive and tries to look at all drives that have defined devices.
Oliver
---output---- err:dosfs:DRIVE_ReadSuperblock Couldn't open device '/dev/fd0' for drive A: ! (no permission) err:dosfs:DRIVE_ReadSuperblock Can't read drive volume info ! Either pre-set it or make sure the device to read it from is accessible ! Perhaps you have not properly edited or created your Wine configuration file. This is (supposed to be) '/home/olsam/.wine/config'
;; MS-DOS drives configuration ;; ;; Each section has the following format: ;; [Drive X] .... ;; "Device"="/dev/xx" (only if you want to allow raw device access) Lawson If you don't want my peaches, then don't shake my tree.
lawson_whitney(a)juno.com wrote:
On Mon, 22 Apr 2002, Oliver Sampson wrote:
Howdy, I'm seeing a strange behavior and I thought I'd let the Devel community know about it:
While using Agent v1.8, and while having a CD in my CD tray (although unmounted!), if I start agent under wine, I'm able to open and close my CD tray. However, if I try to use the attachment window to attach
...
If you don't want Wine to attempt raw device access, don't give it a "Device" = in the [Drive X] entry, I think. Your average Windows app is inquisitive and tries to look at all drives that have defined devices.
It appears to me that there is a new behavior just as Oliver describes. I also had problems this weekend with wine grabbing ahold of the CD and not releasing it, which I don't think has ever been a problem before.
Duane Clark wrote:
lawson_whitney(a)juno.com wrote:
On Mon, 22 Apr 2002, Oliver Sampson wrote:
Howdy, I'm seeing a strange behavior and I thought I'd let the Devel community know about it:
While using Agent v1.8, and while having a CD in my CD tray (although
unmounted!), if I start agent under wine, I'm able to open and close my CD tray. However, if I try to use the attachment window to attach
...
If you don't want Wine to attempt raw device access, don't give it a "Device" = in the [Drive X] entry, I think. Your average Windows app is inquisitive and tries to look at all drives that have defined devices.
It appears to me that there is a new behavior just as Oliver describes. I also had problems this weekend with wine grabbing ahold of the CD and not releasing it, which I don't think has ever been a problem before.
If this is the case then some regression testing is in order. Is it just in agent or are other programs showing this behavior? Tony Lambregts
Tony Lambregts wrote:
If this is the case then some regression testing is in order. Is it just in agent or are other programs showing this behavior?
I guess I should have mentioned that this was not with agent. It was with a program where I was using the CD, but then could not get the CD out of the drive until exiting the wine program.
Oliver Sampson a écrit :
Howdy, I'm seeing a strange behavior and I thought I'd let the Devel community know about it:
While using Agent v1.8, and while having a CD in my CD tray (although unmounted!), if I start agent under wine, I'm able to open and close my CD tray. However, if I try to use the attachment window to attach something, the CD-ROM drive spins up, and I'm unable to open it. Even if I attach nothing, the CD-ROM drive is claimed by wine so that I can't eject the Drive. Once I exit agent, the drive is released so that I can open the drive. Note that the CD-ROM was never mounted. Even a check during the blocked period shows no mounted device, even though the "eject' command says "device busy."
Interestingly, when I just tried this again for this email, I noticed the following output messages (It seems that there are some floppy drive assumptions, also.)
does the attached patch solves the issue ? A+ Index: files/drive.c =================================================================== RCS file: /home/cvs/cvsroot/wine/wine/files/drive.c,v retrieving revision 1.67 diff -u -r1.67 drive.c --- files/drive.c 9 Mar 2002 23:50:37 -0000 1.67 +++ files/drive.c 22 Apr 2002 17:54:52 -0000 @@ -521,6 +521,7 @@ #define DRIVE_SUPER 96 int fd; off_t offs; + int ret = 0; if (memset(buff,0,DRIVE_SUPER)!=buff) return -1; if ((fd=open(DOSDrives[drive].device,O_RDONLY)) == -1) @@ -551,8 +552,16 @@ break; } - if ((offs) && (lseek(fd,offs,SEEK_SET)!=offs)) return -4; - if (read(fd,buff,DRIVE_SUPER)!=DRIVE_SUPER) return -2; + if ((offs) && (lseek(fd,offs,SEEK_SET)!=offs)) + { + ret = -4; + goto the_end; + } + if (read(fd,buff,DRIVE_SUPER)!=DRIVE_SUPER) + { + ret = -2; + goto the_end; + } switch(DOSDrives[drive].type) { @@ -565,20 +574,27 @@ { ERR("The filesystem is not FAT !! (device=%s)\n", DOSDrives[drive].device); - return -3; + ret = -3; + goto the_end; } break; case DRIVE_CDROM: if (strncmp(&buff[1],"CD001",5)) /* Check for iso9660 present */ - return -3; + { + ret = -3; + goto the_end; + } /* FIXME: do we need to check for "CDROM", too ? (high sierra) */ - break; + break; default: - return -3; - break; + ret = -3; + goto the_end; } return close(fd); + the_end: + close(fd); + return ret; }
Eric Pouech wrote:
does the attached patch solves the issue ?
Fixes it for me. And the behavior with CDROMs is now significantly improved over what it used to be. I used to have to click through a couple of dialogs to switch CDs. But now when I am asked to insert a new CD, I can unmount the old one, mount the new, click OK, and the program immediately finds it.
participants (5)
-
Duane Clark -
Eric Pouech -
lawson_whitney＠juno.com -
Oliver Sampson -
Tony Lambregts