Re: [PATCH 1/8] winemac: Don't unminimize a window on first activation during start-up.
Ken Thomases <ken(a)codeweavers.com> wrote:
--- dlls/winemac.drv/cocoa_app.h | 2 ++ dlls/winemac.drv/cocoa_app.m | 3 ++- 2 files changed, 4 insertions(+), 1 deletions(-)
I wonder, do you actually run 'make test' in dlls/user32/tests with your changes? My guess is that you don't. -- Dmitry.
On Jun 4, 2013, at 5:15 AM, Dmitry Timoshkov wrote:
Ken Thomases <ken(a)codeweavers.com> wrote:
--- dlls/winemac.drv/cocoa_app.h | 2 ++ dlls/winemac.drv/cocoa_app.m | 3 ++- 2 files changed, 4 insertions(+), 1 deletions(-)
I wonder, do you actually run 'make test' in dlls/user32/tests with your changes? My guess is that you don't.
In fact, I spent many hours today doing just that. And some of these patches were to fix specific test failures. -Ken
participants (2)
-
Dmitry Timoshkov -
Ken Thomases