Re: [1/13] wineconsole and kernel32: set GetLargestConsoleWindowSize based on screen resolution

[Frédéric Delanoy]

On Mon, Apr 8, 2013 at 2:53 PM, Hugh McMaster <
hugh.mcmaster(a)masterindexing.com> wrote:
> This patch creates winecon_private.h in 'include/wineconsole'. The header
> is now a shared header.  Note that the source code is the same as that in
> programs/wineconsole/winecon_private.h. (This latter file will be removed
> later.)
>
> Tested on Linux Mint 14 and Mac OS X 10.8 (Mountain Lion).
>
> ---
>  include/wineconsole/winecon_private.h |  103
> +++++++++++++++++++++++++++++++++
>  1 file changed, 103 insertions(+)
>  create mode 100644 include/wineconsole/winecon_private.h

Please don't send 13 patches with the same name.
Also, for long patch series, you should describe the whole purpose of the
series in the first patch [1/N] (or even better in a [0/N] patch)

Finally,even if "one change per patch" is the rule, don't overdo it...

Frédéric

[1/13] wineconsole and kernel32: set GetLargestConsoleWindowSize based on screen resolution

[Hugh McMaster]

> Please don't send 13 patches with the same name.
> Also, for long patch series, you should describe the whole purpose of the series in the first patch [1/N] (or even better in a [0/N] patch)
> Finally,even if "one change per patch" is the rule, don't overdo it...

Frédéric

Fair enough. Thank you for the advice.