Re: [PATCH 1/5] wined3d: Don't mess with the device in buffer_create_buffer_object

9 Sep 2013


      On 9 September 2013 12:56, Stefan Dösinger <stefan(a)codeweavers.com> wrote:
...
@@ -148,7 +149,7 @@ static void buffer_create_buffer_object(struct wined3d_buffer *This, const struc
     }
if (This->buffer_type_hint == GL_ELEMENT_ARRAY_BUFFER_ARB)
-        device_invalidate_state(This->resource.device, STATE_INDEXBUFFER);
+        context_invalidate_state(context, STATE_INDEXBUFFER);
     GL_EXTCALL(glBindBufferARB(This->buffer_type_hint, This->buffer_object));
     error = gl_info->gl_ops.gl.p_glGetError();
     if (error != GL_NO_ERROR)
The patch is fine, although I probably would have preferred something
along the lines of "Only invalidate STATE_INDEXBUFFER for the current
context in buffer_create_buffer_object()." for the commit message.

    

Henri Verbeet