Re: shlwapi/tests: test UrlUnEscape inplace behavior (1/2) (try 2)
"Dan Kegel" <dank(a)kegel.com> writes:
Add test showing UrlUnEscape should convert the url in place when URL_UNESCAPE_INPLACE is set, even if the output buffer is NULL. Passes on XP.
Changes since originally posted by Louis Lenders as http://www.winehq.org/pipermail/wine-patches/2008-August/059567.html 1) added todo_wine around parts that fail in Wine 2) he has requested that somebody else take it over, so I am raising my hand.
If you are resending a patch written by someone else you need to include a From: line with the complete attribution. Alternatively if you have made significant changes you need to add a "Based on a patch by" note in the log message. -- Alexandre Julliard julliard(a)winehq.org
On Tue, Aug 26, 2008 at 2:42 AM, Alexandre Julliard <julliard(a)winehq.org> wrote:
If you are resending a patch written by someone else you need to include a From: line with the complete attribution. Alternatively if you have made significant changes you need to add a "Based on a patch by" note in the log message.
I looked but couldn't find any doc for how the From: line is supposed to look, do you mean the smtp From line, or something embedded in the message? I'll try something and see whether you like it :-) We should update http://wiki.winehq.org/SubmittingPatches with all the rules; I'll add one about patch series numbering there. - Dan
"Dan Kegel" <dank(a)kegel.com> writes:
On Tue, Aug 26, 2008 at 2:42 AM, Alexandre Julliard <julliard(a)winehq.org> wrote:
If you are resending a patch written by someone else you need to include a From: line with the complete attribution. Alternatively if you have made significant changes you need to add a "Based on a patch by" note in the log message.
I looked but couldn't find any doc for how the From: line is supposed to look, do you mean the smtp From line, or something embedded in the message? I'll try something and see whether you like it :-)
It should be in the body of the message, in the same format as it would have been on the original mail. The best way is to commit the patch to your tree with the correct authorship information, and then send the complete git-format-patch output with all the headers in the body of your mail. If my commit script detects an embedded git commit in the mail body it will ignore the actual SMTP headers in favor of the git info. -- Alexandre Julliard julliard(a)winehq.org
On Tue, Aug 26, 2008 at 6:48 AM, Alexandre Julliard <julliard(a)winehq.org> wrote:
It should be in the body of the message, in the same format as it would have been on the original mail.
The best way is to commit the patch to your tree with the correct authorship information, and then send the complete git-format-patch output with all the headers in the body of your mail. If my commit script detects an embedded git commit in the mail body it will ignore the actual SMTP headers in favor of the git info.
I updated http://wiki.winehq.org/SubmittingPatches with that info (and lots more, too), and resubmitted the patches.
participants (2)
-
Alexandre Julliard -
Dan Kegel