Small and Fast (was: Re: Add InitializeSecurityContext for schannel)

[Detlef Riekenberg]

Am Dienstag, den 14.02.2006, 17:34 +0530 schrieb Vijay Kiran Kamuju:
> Add InitializeSecurityContext for schannel in secur32.dll

+static SECURITY_STATUS SEC_ENTRY schan_InitializeSecurityContextW(
+ PCredHandle phCredential, PCtxtHandle phContext, SEC_WCHAR
*pszTargetName,
+ ULONG fContextReq, ULONG Reserved1, ULONG TargetDataRep,
+ PSecBufferDesc pInput,ULONG Reserved2, PCtxtHandle phNewContext,
+ PSecBufferDesc pOutput, ULONG *pfContextAttr, PTimeStamp ptsExpiry)
+{

I Remembered a statement from fefe (diet-libc => www.fefe.de) about
"Writing Small and Fast Software":

It is still clear, what each Argument does, when you remove the
Variable-Names from the Declaration?
- Yes: Efficient Design.
- No:  Your Interface is to generic ==  bloated

static SECURITY_STATUS SEC_ENTRY schan_InitializeSecurityContextW(
 PCredHandle, PCtxtHandle, SEC_WCHAR *, ULONG, ULONG, ULONG,
 PSecBufferDesc, ULONG, PCtxtHandle, PSecBufferDesc, ULONG, PTimeStamp)
{

We all should thank the People who did such a Design :-)


-- 
By By ...
      ... Detlef

Small and Fast (was: Re: Add InitializeSecurityContext for schannel)

[Marcus Meissner]

On Tue, Feb 14, 2006 at 11:22:09PM +0100, Detlef Riekenberg wrote:
> Am Dienstag, den 14.02.2006, 17:34 +0530 schrieb Vijay Kiran Kamuju:
> > Add InitializeSecurityContext for schannel in secur32.dll
>
> +static SECURITY_STATUS SEC_ENTRY schan_InitializeSecurityContextW(
> + PCredHandle phCredential, PCtxtHandle phContext, SEC_WCHAR
> *pszTargetName,
> + ULONG fContextReq, ULONG Reserved1, ULONG TargetDataRep,
> + PSecBufferDesc pInput,ULONG Reserved2, PCtxtHandle phNewContext,
> + PSecBufferDesc pOutput, ULONG *pfContextAttr, PTimeStamp ptsExpiry)
> +{
>
> I Remembered a statement from fefe (diet-libc => www.fefe.de) about
> "Writing Small and Fast Software":
>
> It is still clear, what each Argument does, when you remove the
> Variable-Names from the Declaration?
> - Yes: Efficient Design.
> - No:  Your Interface is to generic ==  bloated
>
> static SECURITY_STATUS SEC_ENTRY schan_InitializeSecurityContextW(
>  PCredHandle, PCtxtHandle, SEC_WCHAR *, ULONG, ULONG, ULONG,
>  PSecBufferDesc, ULONG, PCtxtHandle, PSecBufferDesc, ULONG, PTimeStamp)
> {
>
> We all should thank the People who did such a Design :-)

However, this only works in newer C compilers as far as I know... ;)

Ciao, Marcus

Small and Fast (was: Re: Add InitializeSecurityContext for schannel)

[Detlef Riekenberg]

Hi all
> > static SECURITY_STATUS SEC_ENTRY schan_InitializeSecurityContextW(
> >  PCredHandle, PCtxtHandle, SEC_WCHAR *, ULONG, ULONG, ULONG,
> >  PSecBufferDesc, ULONG, PCtxtHandle, PSecBufferDesc, ULONG, PTimeStamp)
> >
> > We all should thank the People who did such a Design :-)
>
> However, this only works in newer C compilers as far as I know... ;)

I never wanted to compile this shortcut, it was just presented as a
fat/bloated Design-Example from the well known big Company.


-- 
By By ...
      ... Detlef