[PATCH v2 1/2] gdi32/tests: Add tests for replacement font properties.
In v2, add tests. These tests are only for Wine. They define replacement font behaviors, which are comparable to a normal font ones, and will prevent regressions in the future. At this point, replacement definitions are used in the font selection in NtGdiSelectFont(), enumeration and lfFaceName in EnumFonts() family. The following patches expands the usage to GetTextFace() and otmpFamilyName in GetOutlineTextMetrics(). Replacement font feature expansion helps to avoid copyright and license issues regarding missing MS fonts, e.g. MS Gothic and Segoe UI. Signed-off-by: Akihiro Sagawa <sagawa.aki(a)gmail.com> --- dlls/gdi32/tests/font.c | 115 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 115 insertions(+)
On Tue, Dec 07, 2021 at 12:19:40AM +0900, Akihiro Sagawa wrote:
In v2, add tests.
These tests are only for Wine. They define replacement font behaviors, which are comparable to a normal font ones, and will prevent regressions in the future.
I don't think it makes much sense to have Wine specific tests. I've sent in the second patch without the test changes (although I've incorrectly labelled it v2 rather than v3!). Huw.
On Tue, 7 Dec 2021 09:42:37 +0000, Huw Davies wrote:
On Tue, Dec 07, 2021 at 12:19:40AM +0900, Akihiro Sagawa wrote:
These tests are only for Wine. They define replacement font behaviors, which are comparable to a normal font ones, and will prevent regressions in the future.
I don't think it makes much sense to have Wine specific tests. I've sent in the second patch without the test changes (although I've incorrectly labelled it v2 rather than v3!).
Sure, there is no problem to omit Wine specific tests. I wondered why my patch wasn't reviewed for more than two weeks. Thanks for reviewing. Akihiro Sagawa
participants (2)
-
Akihiro Sagawa -
Huw Davies