Re: wine.inf.in: create default key App Paths (and key for IEXPLORE)

[Louis. Lenders]

----- Original Message ----
From: Alexandre Julliard <julliard(a)winehq.org>


"Louis. Lenders" <xerox_xerox2000(a)yahoo.co.uk> writes:
> Hi, the key HKLM//Software\\Microsoft\\Windows\\CurrentVersion\\App Paths is needed by LexWare installer (bug http://bugs.winehq.org/show_bug.cgi?id=15347)
>
> This patch creates that key by default, but also creates the key for IEXPLORE along the way, needed to fix http://bugs.winehq.org/show_bug.cgi?id=7257. The key is present on a default winxp installation
>
> btw, was there anything wrong with this patch:
> http://www.winehq.org/pipermail/wine-patches/attachments/20080918/e269df3c/a... ?
> Yes, it doesn't match the Windows definitions. And this patch doesn't
> either. You really need to pay more attention to what you are doing.

honestly, i'm trying to be as careful as i can. But I see an extra semi-colon crawled in in the patch for the registry key for App Paths. Is that what you meant with 'doesn't match Windows definitions'? Or is there something more wrong?

As for the patch for MsiSetExternalUIRecord , i compared again with de definition at http://msdn.microsoft.com/en-us/library/aa370385(VS.85).aspx, but i don't see a problem there. Also i matched the definition for InstalluiHandlerRecord to the definition of InstalluiHandler in wine's msi.h, as that seemed more consistent to me. I'm happy to fix up any patch , if only i knew what was wrong with them...
louis

wine.inf.in: create default key App Paths (and key for IEXPLORE)

[James Hawkins]

On Tue, Sep 23, 2008 at 12:23 PM, Louis. Lenders
<xerox_xerox2000(a)yahoo.co.uk> wrote:
> As for the patch for MsiSetExternalUIRecord , i compared again with de
> definition at http://msdn.microsoft.com/en-us/library/aa370385(VS.85).aspx,
> but i don't see a problem there. Also i matched the definition for
> InstalluiHandlerRecord to the definition of InstalluiHandler in wine's
> msi.h, as that seemed more consistent to me. I'm happy to fix up any patch ,
> if only i knew what was wrong with them...
> louis

msdn is often wrong.  The only standard we adhere to is the PSDK.

-- 
James Hawkins