Re: user32: Partially implement FlashWindowEx with tests

[Dmitry Timoshkov]

André Hentschel <nerv(a)dawncrow.de> wrote:
> +    if (!pfwi->hwnd || pfwi->cbSize < sizeof(FLASHWINFO))
> +    {
> +        SetLastError(ERROR_INVALID_PARAMETER);
> +        return FALSE;
> +    }

I don't see in your tests the case for 'cbSize > sizeof(FLASHWINFO)'.
Also using !IsWindow() instead of !hwnd would fix one more test case.

-- 
Dmitry.

user32: Partially implement FlashWindowEx with tests

[André Hentschel]

Am 22.05.2011 09:58, schrieb Dmitry Timoshkov:
> André Hentschel <nerv(a)dawncrow.de> wrote:
> > +    if (!pfwi->hwnd || pfwi->cbSize < sizeof(FLASHWINFO))
> > +    {
> > +        SetLastError(ERROR_INVALID_PARAMETER);
> > +        return FALSE;
> > +    }
>
> I don't see in your tests the case for 'cbSize > sizeof(FLASHWINFO)'.
> Also using !IsWindow() instead of !hwnd would fix one more test case.

Thanks, will get into try 2

-- 

Best Regards, André Hentschel

user32: Partially implement FlashWindowEx with tests

[Detlef Riekenberg]

On So, 2011-05-22, André Hentschel wrote
> Thanks, will get into try 2
> pfwi->cbSize < sizeof(FLASHWINFO) || pfwi->cbSize > sizeof(FLASHWINFO)

That code can be reduced to:

pfwi->cbSize != sizeof(FLASHWINFO)


-- 
By by ... Detlef