Re: [PATCH 1/2] user32/tests/win.c: Fix Win9x detection
Michael Karcher <wine(a)mkarcher.dialup.fu-berlin.de> wrote:
The current code misdetects both Windows XP and Wine as Win9x and skips some tests due to this. The SetParent tests were not passing on XP, so this patch also removes the tests that fail on XP SP3.
These should be 2 separate patches. And according to http://test.winehq.org/data/e2af560aa3c23a672d8680f91f3e1b8793d5827f/index_X... SetParent tests pass under XP just fine. -- Dmitry.
Am Montag, den 25.01.2010, 15:27 +0800 schrieb Dmitry Timoshkov:
The current code misdetects both Windows XP and Wine as Win9x and skips some tests due to this. The SetParent tests were not passing on XP, so this patch also removes the tests that fail on XP SP3.
These should be 2 separate patches.
And according to http://test.winehq.org/data/e2af560aa3c23a672d8680f91f3e1b8793d5827f/index_X... SetParent tests pass under XP just fine.
No, they don't pass on Windows XP. But they also don't fail on Windows XP, because they are not run at all, because the Win9x detection is wrong. If I make two separate patches out of it, we either have a no-op-patch (changing tests that are not run), or we have an interim version that fails tests on Windows XP. no-op-patches won't help in bisecting, as you will always bisect to the enabling patch, and I used to think that interim versions that fail tests are frowned upon. Thank you for looking at the patch nevertheless, Michael Karcher
Michael Karcher <wine(a)mkarcher.dialup.fu-berlin.de> wrote:
And according to http://test.winehq.org/data/e2af560aa3c23a672d8680f91f3e1b8793d5827f/index_X... SetParent tests pass under XP just fine.
No, they don't pass on Windows XP. But they also don't fail on Windows XP, because they are not run at all, because the Win9x detection is wrong.
Since it's me who have written these tests in 2005 I'm pretty sure that the tests were passing at that time. And since I create the tests under XP and only before sending do test them under Win98 I have added broken is_win9x check once I noticed Win98 crashing in that test. So, broken win9x check was added after the test has been tested under XP. This needs retesting under different Windows versions before removing the tests. I'd recommend to fix the broken is_win9x check first, and watch test.winehq.org for awhile for results. -- Dmitry.
On 01/25/2010 09:37 AM, Michael Karcher wrote:
Am Montag, den 25.01.2010, 15:27 +0800 schrieb Dmitry Timoshkov:
The current code misdetects both Windows XP and Wine as Win9x and skips some tests due to this. The SetParent tests were not passing on XP, so this patch also removes the tests that fail on XP SP3.
These should be 2 separate patches.
And according to http://test.winehq.org/data/e2af560aa3c23a672d8680f91f3e1b8793d5827f/index_X... SetParent tests pass under XP just fine.
No, they don't pass on Windows XP. But they also don't fail on Windows XP, because they are not run at all, because the Win9x detection is wrong.
I just checked with a XP-SP3 box on winetestbot and added the flag to show the winetest successes: https://winetestbot.geldorp.nl/JobDetails.pl?Key=420 This clearly shows that the tests are run. I'm not saying they run on every XP box btw. Nonetheless, it could be a smart move to have 1 point of detection instead of several. -- Cheers, Paul.
Am Montag, den 25.01.2010, 10:47 +0100 schrieb Paul Vriens:
On 01/25/2010 09:37 AM, Michael Karcher wrote:
Am Montag, den 25.01.2010, 15:27 +0800 schrieb Dmitry Timoshkov:
The current code misdetects both Windows XP and Wine as Win9x and skips some tests due to this. The SetParent tests were not passing on XP, so this patch also removes the tests that fail on XP SP3.
I just checked with a XP-SP3 box on winetestbot and added the flag to show the winetest successes:
https://winetestbot.geldorp.nl/JobDetails.pl?Key=420
This clearly shows that the tests are run. I'm not saying they run on every XP box btw.
It shows only lines 3236 to 3250 being run - these are the tests that are not protected by the broken is_win9x check. The interesting tests this patch touches and I claim (a) not to be run and (b) failing on some systems like my XP SP3 box are in lines 3254 to 3260 and the following check_parents calls. I hope I didn't miss something important in that analysis. Regards, Michael Karcher
On 01/25/2010 11:30 AM, Michael Karcher wrote:
Am Montag, den 25.01.2010, 10:47 +0100 schrieb Paul Vriens:
On 01/25/2010 09:37 AM, Michael Karcher wrote:
Am Montag, den 25.01.2010, 15:27 +0800 schrieb Dmitry Timoshkov:
The current code misdetects both Windows XP and Wine as Win9x and skips some tests due to this. The SetParent tests were not passing on XP, so this patch also removes the tests that fail on XP SP3.
I just checked with a XP-SP3 box on winetestbot and added the flag to show the winetest successes:
https://winetestbot.geldorp.nl/JobDetails.pl?Key=420
This clearly shows that the tests are run. I'm not saying they run on every XP box btw.
It shows only lines 3236 to 3250 being run - these are the tests that are not protected by the broken is_win9x check.
So are all these checks broken according to you or just specific ones?
The interesting tests this patch touches and I claim (a) not to be run and (b) failing on some systems like my XP SP3 box are in lines 3254 to 3260 and the following check_parents calls.
Is the report of your box on test.winehq.org?
I hope I didn't miss something important in that analysis.
Regards, Michael Karcher
-- Cheers, Paul.
Am Montag, den 25.01.2010, 12:49 +0100 schrieb Paul Vriens:
It shows only lines 3236 to 3250 being run - these are the tests that are not protected by the broken is_win9x check. So are all these checks broken according to you or just specific ones?
The patch that started this thread contained a patch that removes the SetParent calls that failed on my XP SP3 system but were supposed to work, as behaviour seems to be inconsistent on these calls. I adjusted the expectation in the check_parent calls to that what you get if you omit the problematic SetParent calls.
The interesting tests this patch touches and I claim (a) not to be run and (b) failing on some systems like my XP SP3 box are in lines 3254 to 3260 and the following check_parents calls. Is the report of your box on test.winehq.org? No, my box is not on test.winehq.org, but as the broken tests are not run by the currently provided binaries (because of the also broken win9x checks), it wouldn't help.
Regards, Michael Karcher
participants (3)
-
Dmitry Timoshkov -
Michael Karcher -
Paul Vriens