Re: user[2/2]: Preserve LastError.

[Detlef Riekenberg]

Vitaliy Margolen wrote:
> ChangeLog:
> user: Preserve LastError.

You can move the ok() for GetLastError() direct after GetKeyNameTextA():
> +        SetLastError(0xdeadbeef);
>          len = GetKeyNameTextA(i << 16, buff, sizeof(buff));
> +        ok( GetLastError() == 0xdeadbeef,
> +            "%d Wrong LastError = %ld\n", i, GetLastError());
>          ok(len | !buff[0], "%d: Buffer is not zeroed\n", i);

Just my 2 ¢


-- 
By By ...
      ... Detlef

user[2/2]: Preserve LastError.

[Vitaliy Margolen]

Sunday, July 30, 2006, 6:29:43 AM, Detlef Riekenberg wrote:
> Vitaliy Margolen wrote:
> > ChangeLog:
> > user: Preserve LastError.
> You can move the ok() for GetLastError() direct after GetKeyNameTextA():
> > +        SetLastError(0xdeadbeef);
> >          len = GetKeyNameTextA(i << 16, buff, sizeof(buff));
> > +        ok( GetLastError() == 0xdeadbeef,
> > +            "%d Wrong LastError = %ld\n", i, GetLastError());
> >          ok(len | !buff[0], "%d: Buffer is not zeroed\n", i);
> Just my 2 ¢
> Those 2 ¢ would be spent better looking over wine-devel. What you proposed is
> not correct.

Vitaliy