[PATCH resend 6/7] comctl32/tests: fix invalidation in static control tests

[Rafał Harabień]

Rectangle used for invalidation was outside of windows rect of static
controls with SS_ETCHEDHORZ/SS_ETCHEDVERT style because they resize
after creation. Improve test by changing the invalidated rect and
add more details in comment about SS_ETCHEDHORZ/SS_ETCHEDVERT styles.

Signed-off-by: Rafał Harabień <rafalh92(a)outlook.com>
---
 dlls/comctl32/tests/static.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/dlls/comctl32/tests/static.c b/dlls/comctl32/tests/static.c
index 324301212dc..a07dbcc26bf 100644
--- a/dlls/comctl32/tests/static.c
+++ b/dlls/comctl32/tests/static.c
@@ -82,7 +82,7 @@ static LRESULT CALLBACK WndProc(HWND hwnd, UINT msg, WPARAM wparam, LPARAM lpara
 static void test_updates(int style, int flags)
 {
     HWND hStatic = create_static(style);
-    RECT r1 = {20, 20, 30, 30}, rcClient;
+    RECT r1 = {5, 5, 30, 30}, rcClient;
     int exp;
     LONG exstyle;
 
@@ -128,7 +128,7 @@ static void test_updates(int style, int flags)
     if (style != SS_ETCHEDHORZ && style != SS_ETCHEDVERT)
         exp = 4;
     else
-        exp = 1; /* SS_ETCHED* seems to send WM_CTLCOLORSTATIC only sometimes */
+        exp = 2; /* SS_ETCHEDHORZ/SS_ETCHEDVERT have empty client rect so WM_CTLCOLORSTATIC is sent only when parent window is invalidated */
 
     if (flags & TODO_COUNT)
     todo_wine
-- 
2.25.1

[Marvin]

Hi,

While running your changed tests, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=111331

Your paranoid android.


=== build (build log) ===

error: patch failed: dlls/user32/static.c:425
Task: Patch failed to apply

=== debian11 (build log) ===

error: patch failed: dlls/user32/static.c:425
Task: Patch failed to apply

=== debian11 (build log) ===

error: patch failed: dlls/user32/static.c:425
Task: Patch failed to apply