Re: [PATCH] d3dx9_33: Share the source with d3dx9_36

[Matteo Bruni]

2016-06-10 10:33 GMT+02:00 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>:
> Fixes: https://bugs.winehq.org/show_bug.cgi?id=21817
>
> Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>
> ---
>  dlls/d3dx9_33/Makefile.in     |  22 +-
>  dlls/d3dx9_33/d3dx9_33.spec   | 667 +++++++++++++++++++++---------------------
>  dlls/d3dx9_33/d3dx9_33_main.c |  19 ++
>  tools/make_specfiles          |   1 -
>  4 files changed, 373 insertions(+), 336 deletions(-)
>
> diff --git a/dlls/d3dx9_33/Makefile.in b/dlls/d3dx9_33/Makefile.in
> index 0934eab..1106d11 100644
> --- a/dlls/d3dx9_33/Makefile.in
> +++ b/dlls/d3dx9_33/Makefile.in
> @@ -1,7 +1,25 @@
>  MODULE    = d3dx9_33.dll
> -IMPORTS   = d3d9
> +IMPORTS   = d3d9 d3dcompiler dxguid d3dxof ole32 gdi32 user32 wined3d

You don't want to import wined3d here.

It looks good otherwise, at a quick glance. Do you mind also writing
similar patches for the other d3dx9_xx and d3dcompiler_xx DLLs?