[PATCH 2/2] tapi32: Add lineGetTranslateCapsW function

[Vijay Kiran Kamuju]

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=38585

Signed-off-by: Vijay Kiran Kamuju <infyquest(a)gmail.com>
---
 dlls/tapi32/line.c      | 6 ++++++
 dlls/tapi32/tapi32.spec | 1 +
 2 files changed, 7 insertions(+)

diff --git a/dlls/tapi32/line.c b/dlls/tapi32/line.c
index a44ac1a1a726..e0f85cbc9449 100644
--- a/dlls/tapi32/line.c
+++ b/dlls/tapi32/line.c
@@ -1135,6 +1135,12 @@ DWORD WINAPI lineGetTranslateCapsA(HLINEAPP hLineApp, DWORD dwAPIVersion,
     return 0; /* success */
 }
 
+DWORD WINAPI lineGetTranslateCapsW(HLINEAPP hLineApp, DWORD dwAPIVersion,
+        LPLINETRANSLATECAPS lpTranslateCaps)
+{
+    return lineGetTranslateCapsA(hLineApp, dwAPIVersion, lpTranslateCaps);
+}
+
 /***********************************************************************
  *		lineHandoff (TAPI32.@)
  */
diff --git a/dlls/tapi32/tapi32.spec b/dlls/tapi32/tapi32.spec
index 62631efe236f..39ab7c1bf2f6 100644
--- a/dlls/tapi32/tapi32.spec
+++ b/dlls/tapi32/tapi32.spec
@@ -67,6 +67,7 @@
 @ stdcall lineGetStatusMessages(long ptr ptr)
 @ stdcall lineGetTranslateCaps(long long ptr) lineGetTranslateCapsA
 @ stdcall lineGetTranslateCapsA(long long ptr)
+@ stdcall lineGetTranslateCapsW(long long ptr)
 @ stdcall lineHandoff(long str long) lineHandoffA
 @ stdcall lineHandoffA(long str long)
 @ stdcall lineHold(long)
-- 
2.21.0

[Alistair Leslie-Hughes]

Hi Vijay,

This isn't going to work as expected.

Function lineGetTranslateCapsA has

lpTranslateCaps->dwNeededSize =  sizeof(LINETRANSLATECAPS) + length;

This length is the size of the data in char's not WCHAR.

This module doesn't have tests at the moment, maybe it should.

Alistair.


On 1/11/19 7:56 pm, Vijay Kiran Kamuju wrote:
> Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=38585
>
> Signed-off-by: Vijay Kiran Kamuju <infyquest(a)gmail.com>
> ---
>   dlls/tapi32/line.c      | 6 ++++++
>   dlls/tapi32/tapi32.spec | 1 +
>   2 files changed, 7 insertions(+)
>
> diff --git a/dlls/tapi32/line.c b/dlls/tapi32/line.c
> index a44ac1a1a726..e0f85cbc9449 100644
> --- a/dlls/tapi32/line.c
> +++ b/dlls/tapi32/line.c
> @@ -1135,6 +1135,12 @@ DWORD WINAPI lineGetTranslateCapsA(HLINEAPP hLineApp, DWORD dwAPIVersion,
>       return 0; /* success */
>   }
>
> +DWORD WINAPI lineGetTranslateCapsW(HLINEAPP hLineApp, DWORD dwAPIVersion,
> +        LPLINETRANSLATECAPS lpTranslateCaps)
> +{
> +    return lineGetTranslateCapsA(hLineApp, dwAPIVersion, lpTranslateCaps);
> +}
> +
>   /***********************************************************************
>    *		lineHandoff (TAPI32.@)
>    */
> diff --git a/dlls/tapi32/tapi32.spec b/dlls/tapi32/tapi32.spec
> index 62631efe236f..39ab7c1bf2f6 100644
> --- a/dlls/tapi32/tapi32.spec
> +++ b/dlls/tapi32/tapi32.spec
> @@ -67,6 +67,7 @@
>   @ stdcall lineGetStatusMessages(long ptr ptr)
>   @ stdcall lineGetTranslateCaps(long long ptr) lineGetTranslateCapsA
>   @ stdcall lineGetTranslateCapsA(long long ptr)
> +@ stdcall lineGetTranslateCapsW(long long ptr)
>   @ stdcall lineHandoff(long str long) lineHandoffA
>   @ stdcall lineHandoffA(long str long)
>   @ stdcall lineHold(long)