Re: winemp3.acm: Fixes the Mac-specific code (try 2)

[Aric Stewart]

Hi,

  I was excited to try out this patch but now it is giving me a crash. 
(OS/X 10.5.8)

Backtrace:
=>0 0xffff12a9 (0x0033d81c)
   1 0xffff086e (0x0033d838)
   2 0x936f5a47 
_ZN14CodecConverter14AppendNewInputEmPcmRmP28AudioStreamPacketDescription+0xb6() 
in audiotoolbox (0x0033d888)
   3 0x936f564b _ZN14CodecConverter13CallInputProcERm+0x1ca() in 
audiotoolbox (0x0033d8f8)
   4 0x936f513d 
_ZN14CodecConverter17DecoderFillBufferERmR15AudioBufferListP28AudioStreamPacketDescription+0x47c() 
in audiotoolbox (0x0033d9c8)
   5 0x936e9b61 
_ZN22BufferedAudioConverter13GetInputBytesEmRmRPK12CABufferList+0xa0() 
in audiotoolbox (0x0033d9f8)
   6 0x936e9a1d 
_ZN12CBRConverter12RenderOutputEP12CABufferListmRmP28AudioStreamPacketDescription+0x7c() 
in audiotoolbox (0x0033da38)
   7 0x936e978c 
_ZN22BufferedAudioConverter10FillBufferERmR15AudioBufferListP28AudioStreamPacketDescription+0xeb() 
in audiotoolbox (0x0033da98)
   8 0x936e9b61 
_ZN22BufferedAudioConverter13GetInputBytesEmRmRPK12CABufferList+0xa0() 
in audiotoolbox (0x0033dac8)
   9 0x936e9a1d 
_ZN12CBRConverter12RenderOutputEP12CABufferListmRmP28AudioStreamPacketDescription+0x7c() 
in audiotoolbox (0x0033db08)
   10 0x936e978c 
_ZN22BufferedAudioConverter10FillBufferERmR15AudioBufferListP28AudioStreamPacketDescription+0xeb() 
in audiotoolbox (0x0033db68)
   11 0x936e9914 
_ZN19AudioConverterChain12RenderOutputEP12CABufferListmRmP28AudioStreamPacketDescription+0x63() 
in audiotoolbox (0x0033dba8)
   12 0x936e978c 
_ZN22BufferedAudioConverter10FillBufferERmR15AudioBufferListP28AudioStreamPacketDescription+0xeb() 
in audiotoolbox (0x0033dc08)
   13 0x93700b23 AudioConverterFillComplexBuffer+0x112() in audiotoolbox 
(0x0033dc58)
   14 0x57b4f560 _mp3_leopard_horse+0x2bf() in winemp3 (0x0033dd08)
   15 0x57b4f9a5 _MPEG3_DriverProc+0xf4() in winemp3 (0x0033ddd8)


Here is the mpeg log snipit from just before the crash:

trace:mpeg3:MPEG3_DriverProc (00000000 0x27af350 0003 00000000 0033de0c);
trace:mpeg3:MPEG3_DriverProc (00000001 0x27af350 601b 0033dea8 00000000);
trace:mpeg3:MPEG3_DriverProc (00000000 0x1114418 0003 00000000 0033dd9c);
trace:mpeg3:MPEG3_DriverProc (00000001 0x1114418 604c 008f757c 00000000);
trace:mpeg3:MPEG3_DriverProc (00000001 0x1114418 604e 008f757c 0033deb0);
trace:mpeg3:MPEG3_DriverProc (00000001 0x1114418 6051 008f757c 0033df44);
trace:mpeg3:MPEG3_DriverProc (00000001 0x1114418 604f 008f757c 0033df44);
trace:mpeg3:mp3_leopard_horse ndst 147456 0x3127860  <-  19901 0x3122a94
trace:mpeg3:mp3_leopard_horse First 16 bytes to input: 
"\x00\x1f\x84\n\x92_\x81h\x00\x00\x00\x00\x00\x00\x00\x00"

I am also getting quite a number of build warning that i dont know if 
should be concerning.

Anything more I can do to test for you?
-aric

Kristofer Henriksson wrote:
> Second submission, which improves the previous patch by properly
> syncing to the initial MP3 frame header.
>
> The current winemp3.acm does not work if the Mac-specific code is
> used. This rewrites the relevant portion to fix, for example,
> background music on things like Oblivion.
>
> ------------------------------------------------------------------------