[PATCH] mf/tests: Attempt to fix test crashes on some test boxes.

[Nikolay Sivov]

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com>
---
 dlls/mf/tests/mf.c | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)

diff --git a/dlls/mf/tests/mf.c b/dlls/mf/tests/mf.c
index eb681a8b9a7..0d4cb05711a 100644
--- a/dlls/mf/tests/mf.c
+++ b/dlls/mf/tests/mf.c
@@ -4498,15 +4498,18 @@ todo_wine {
     hr = IMFMediaSink_AddStreamSink(sink, 1, NULL, &stream_sink2);
     ok(hr == S_OK, "Unexpected hr %#x.\n", hr);
 
-    hr = MFGetService((IUnknown *)stream_sink2, &MR_VIDEO_ACCELERATION_SERVICE, &IID_IMFVideoSampleAllocator,
-            (void **)&allocator);
-    ok(hr == S_OK, "Unexpected hr %#x.\n", hr);
-    IMFVideoSampleAllocator_Release(allocator);
+    if (SUCCEEDED(hr))
+    {
+        hr = MFGetService((IUnknown *)stream_sink2, &MR_VIDEO_ACCELERATION_SERVICE, &IID_IMFVideoSampleAllocator,
+                (void **)&allocator);
+        ok(hr == S_OK, "Unexpected hr %#x.\n", hr);
+        IMFVideoSampleAllocator_Release(allocator);
 
-    hr = IMFMediaSink_RemoveStreamSink(sink, 1);
-    ok(hr == S_OK, "Unexpected hr %#x.\n", hr);
+        hr = IMFMediaSink_RemoveStreamSink(sink, 1);
+        ok(hr == S_OK, "Unexpected hr %#x.\n", hr);
 
-    IMFStreamSink_Release(stream_sink2);
+        IMFStreamSink_Release(stream_sink2);
+    }
 
     hr = IMFMediaSink_GetCharacteristics(sink, &flags);
     ok(hr == S_OK, "Unexpected hr %#x.\n", hr);
-- 
2.33.0

[Marvin]

Hi,

While running your changed tests, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=102408

Your paranoid android.


=== w8adm (32 bit report) ===

mf:
mf.c:4286: Test failed: Unexpected hr 0x800401f0.